Open
Conversation
4 tasks
madsmtm
force-pushed
the
madsmtm/softbuffer-fill-remove
branch
2 times, most recently
from
2f92d98 to
c40cdde
Compare
By using `OwnedDisplayHandle`, which uses reference-counting, instead of `DisplayHandle<'static>` (where the user has to guarantee that the Application doesn't outlive the event loop).
madsmtm
force-pushed
the
madsmtm/softbuffer-fill-remove
branch
from
c40cdde to
c009698
Compare
This is unsound, and makes the examples harder for people to follow. This is possible nowadays with `OwnedDisplayHandle`.
madsmtm
force-pushed
the
madsmtm/softbuffer-fill-remove
branch
from
c009698 to
b33122a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OwnedDisplayHandle(introduced in #3395) allows getting a reference-counted handle to the connection to the compositor, which we can pass onwards tosoftbuffer::Contextto allow it to talk to the compositor too.This PR updates our examples to use it, which removes the
unsafe, and makes it easier for people to follow along (we no longer need thethread_local!hack, so the example code is more localized).