Update softbuffer source, fix example files and add 2 new axample files #4513
Update softbuffer source, fix example files and add 2 new axample files #4513yagizgil wants to merge 32 commits intorust-windowing:masterfrom
Conversation
winit-orbital/src/event_loop.rs
Outdated
| orbclient::K_NUM_7 => (KeyCode::Numpad7, None), | ||
| orbclient::K_NUM_8 => (KeyCode::Numpad8, None), | ||
| orbclient::K_NUM_9 => (KeyCode::Numpad9, None), | ||
| orbclient::K_NUM_ASTERISK => (KeyCode::NumpadMultiply, None), |
There was a problem hiding this comment.
Adding keyboard mappings is a simple change that should be done in another PR, in my opinion
There was a problem hiding this comment.
I've removed the keyboard mappings from this PR to keep it focused. I will open a separate PR
yagizgil
changed the title
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
softbuffer v0.5 is still in the works, I'd prefer to not change Winit's examples until it's released.
What's the motivation for the two new examples? It's not clear to me whether they showcase something specific?
|
(#4520 might do a lot of what you'd want too btw). |
I added these examples to measure softbuffer's performance within winit and see the FPS improvements clearly. If you don't want new examples right now, I can remove them. |
|
Winit isn't really performance-sensitive in that manner (it is performance-sensitive in terms of "we should correctly implement frame pacing", which we currently don't), I'd prefer for FPS counters etc. to live in Softbuffer. |
3 participants
changelogmodule if knowledge of this change could be valuable to usersI have add missing scancodes for Redox.
I have switch softbuffer dependency to github master. The crates.io version is outdated and lacks the next_buffer function.
I have update examples/util/fill.rs to use new next_buffer and pixels_iter APIs, as the previus .fill() methıd has been removed in the latest softbuffer version.
I have add two new example files, and verified on redox and windows.