Skip to content

RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per product in UI for residential gateway #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar464 wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per product in UI for residential gateway #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
875fa43
RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per…
pavankumar464 Apr 20, 2026
3031959
RDKB-64534 MTA Line details needs to be fixed as per product in UI fo…
pavankumar464 Apr 24, 2026
b7ac68d
Merge branch 'develop' into bug/RDKB-64534
pavankumar464 Apr 29, 2026
b91d442
RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per…
pavankumar464 May 4, 2026
e7303dd
RDKB-64534 mta_Line_Diagnostics.jst
pavankumar464 May 5, 2026
3c47975
Potential fix for pull request finding
pavankumar464 May 5, 2026
99b6cb2
Potential fix for pull request finding
pavankumar464 May 5, 2026
702632f
RDKB-64534 Fix voice_quality_metrics.jst: dynamic msg_no_data element…
Copilot May 5, 2026
f3834b7
Potential fix for pull request finding
pavankumar464 May 5, 2026
d2047b6
RDKB-64534 Fix ES6 compat, ID collision, textarea val, line guard, an…
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 57 additions & 48 deletions source/Styles/xb3/jst/actionHandler/ajaxSet_mta_Line_Diagnostics.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,60 +22,69 @@ if ($_SESSION["loginuser"] == "" || $_SESSION["loginuser"] == false || (!isset($
echo( '<script type="text/javascript">alert("Please Login First!"); location.href="../index.jst";</script>');
exit(0);
}
function TransEmpty($v)
{
return (""==$v) ? "Failed" : $v;
}
var $LineTableNumberOfEntries = Number(getStr("Device.X_CISCO_COM_MTA.LineTableNumberOfEntries"));
var $arConfig = {};
if (isset($_GET['get_statusx']))
{
$line1hook = getStr("Device.X_CISCO_COM_MTA.LineTable.1.Status");
$line2hook = getStr("Device.X_CISCO_COM_MTA.LineTable.2.Status");
$linexhook = "On-Hook";
sleep(2);
if ("Off-Hook"==$line1hook || "Off-Hook"==$line2hook){
$linexhook = "Off-Hook";
$linexhook = "On-Hook";
for ($i = 1; $i <= $LineTableNumberOfEntries; $i++) {
$lineHook = getStr("Device.X_CISCO_COM_MTA.LineTable."+$i+".Status");
if ($lineHook === "Off-Hook") {
$linexhook = "Off-Hook";
break; // no need to check further
}
}
// $linexhook = "Off-Hook";
$arConfig = {'linexhook':$linexhook}/*p2j-array*/;
}
else if (isset($_GET['get_status1']))
{
$line1hook = getStr("Device.X_CISCO_COM_MTA.LineTable.1.Status");
sleep(2);
// $line1hook = "On-Hook";
$arConfig = {'line1hook':$line1hook}/*p2j-array*/;
}
else if (isset($_GET['get_status2']))
{
$line2hook = getStr("Device.X_CISCO_COM_MTA.LineTable.2.Status");
sleep(2);
// $line2hook = "Off-Hook";
$arConfig = {'line2hook':$line2hook}/*p2j-array*/;
}
else if (isset($_GET['start_diagnostics1']))
{
setStr("Device.X_CISCO_COM_MTA.LineTable.1.TriggerDiagnostics", "true", true);
LogStr( " : webui_event:MTA_line1_diag" );
sleep(15);
$line1hp = getStr("Device.X_CISCO_COM_MTA.LineTable.1.HazardousPotential");
$line1femf = getStr("Device.X_CISCO_COM_MTA.LineTable.1.ForeignEMF");
$line1rf = getStr("Device.X_CISCO_COM_MTA.LineTable.1.ResistiveFaults");
$line1roh = getStr("Device.X_CISCO_COM_MTA.LineTable.1.ReceiverOffHook");
$line1re = getStr("Device.X_CISCO_COM_MTA.LineTable.1.RingerEquivalency");
$arConfig = {'line1hp':$line1hp, 'line1femf':$line1femf, 'line1rf':$line1rf, 'line1roh':$line1roh, 'line1re':$line1re}/*p2j-array*/;
$arConfig = {'linexhook':$linexhook}/*p2j-array*/;
}
else if (isset($_GET['start_diagnostics2']))
{
setStr("Device.X_CISCO_COM_MTA.LineTable.2.TriggerDiagnostics", "true", true);
LogStr( " : webui_event:MTA_line2_diag" );
sleep(15);
$line2hp = getStr("Device.X_CISCO_COM_MTA.LineTable.2.HazardousPotential");
$line2femf = getStr("Device.X_CISCO_COM_MTA.LineTable.2.ForeignEMF");
$line2rf = getStr("Device.X_CISCO_COM_MTA.LineTable.2.ResistiveFaults");
$line2roh = getStr("Device.X_CISCO_COM_MTA.LineTable.2.ReceiverOffHook");
$line2re = getStr("Device.X_CISCO_COM_MTA.LineTable.2.RingerEquivalency");
$arConfig = {'line2hp':$line2hp, 'line2femf':$line2femf, 'line2rf':$line2rf, 'line2roh':$line2roh, 'line2re':$line2re}/*p2j-array*/;
else {
$line = null;
$action = null;

/* Detect line number using explicit isset checks (ES5-compatible) */
for ($i = 1; $i <= $LineTableNumberOfEntries; $i++) {
if (isset($_GET["get_status"+$i])) {
$line = $i;
$action = "get_status";
break;
} else if (isset($_GET["start_diagnostics"+$i])) {
$line = $i;
$action = "start_diagnostics";
break;
}
}

if ($line !== null && $action !== null) {

/* ===== GET STATUS ===== */
if ($action == "get_status") {

$linehook = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".Status");
sleep(2);

$arConfig["line"+$line+"hook"] = $linehook;
}
Comment on lines +62 to +66
Copy link
Copy Markdown
Contributor Author

@pavankumar464 pavankumar464 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown

Copilot AI May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already applied in commit d2047b6. Both the get_status response (line 65) and start_diagnostics response (lines 81–85) now use ES5 bracket assignment ($arConfig["line"+$line+"hook"] = $linehook) instead of ES6 computed property name object literals.


/* ===== START DIAGNOSTICS ===== */
else if ($action == "start_diagnostics") {

setStr(
"Device.X_CISCO_COM_MTA.LineTable."+$line+".TriggerDiagnostics",
"true",
true
);
Comment on lines +57 to +75

LogStr(" : webui_event:MTA_line"+$line+"_diag");

sleep(15);

$arConfig["line"+$line+"hp"] = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".HazardousPotential");
$arConfig["line"+$line+"femf"] = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".ForeignEMF");
$arConfig["line"+$line+"rf"] = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".ResistiveFaults");
$arConfig["line"+$line+"roh"] = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".ReceiverOffHook");
$arConfig["line"+$line+"re"] = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".RingerEquivalency");
}
}
}
header("Content-Type: application/json");
$jsConfig = json_encode($arConfig);
Expand Down
23 changes: 16 additions & 7 deletions source/Styles/xb3/jst/locale/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,22 +643,31 @@ $("#mocadiagmess17").text($.i18n("MoCA Network Diagram"));
$("#refresh").prop("value", $.i18n('Refresh'));
$("#mtalinhead").text($.i18n("Gateway > Connection > MTA > Line Diagnostics"));
$("#mtalintip1").text($.i18n("Information related to the MTA Line Diagnostics."));
$("#mtalinmess1").text($.i18n("MTA Line 1 Diagnostics"));
$("[id^='mtalinmess2']").text($.i18n("Hazardous Potential:"));
$("#line1hp,#line1hp,#line1femf,#line1rf,#line1roh,#line1re,#line2hp,#line2femf,#line2rf,#line2roh,#line2re").text($.i18n("Not Started"));
$("[id^='line'][id$='hp'],[id^='line'][id$='femf'],[id^='line'][id$='rf'],[id^='line'][id$='roh'],[id^='line'][id$='re']").val($.i18n("Not Started"));
$("[id^='mtalinmess3']").text($.i18n("Foreign EMF:"));
$("[id^='mtalinmess4']").text($.i18n("Receiver Off Hook:"));
$("[id^='mtalinmess5']").text($.i18n("Ringer Equivalency:"));
$("#start_diagnostics1,#start_diagnostics2").prop("value", $.i18n('Start Diagnostics'));
$("#mtalinmess6").text($.i18n("MTA Line 2 Diagnostics"));
$("#mtalinmess6").text($.i18n("MTA Line 2 Diagnostics"));
$("#mtalinmess6").text($.i18n("MTA Line 2 Diagnostics"));
$("#mtalinmess6").text($.i18n("MTA Line 2 Diagnostics"));
$("[id^='start_diagnostics']").prop("value", $.i18n('Start Diagnostics'));
$("#mtalinediag1").text($.i18n("MTA Line 1 Diagnostics"));
$("#mtalinediag2").text($.i18n("MTA Line 2 Diagnostics"));
$("#mtalinediag3").text($.i18n("MTA Line 3 Diagnostics"));
$("#mtalinediag4").text($.i18n("MTA Line 4 Diagnostics"));
$("#mtalinediag5").text($.i18n("MTA Line 5 Diagnostics"));
$("#mtalinediag6").text($.i18n("MTA Line 6 Diagnostics"));
$("#mtalinediag7").text($.i18n("MTA Line 7 Diagnostics"));
$("#mtalinediag8").text($.i18n("MTA Line 8 Diagnostics"));
$("#mtalinstathead").text($.i18n("Gateway > Connection > MTA > Line Status"));
$("#mtalinstattip1").text($.i18n("Information related to the MTA Line Status."));
$("#mtalinstatmess1").text($.i18n("MTA Line Status"));
$("#mtalinstatmess2").text($.i18n("Line 1 Status:"));
$("#mtalinstatmess3").text($.i18n("Line 2 Status:"));
$("#mtalinstatmess4").text($.i18n("Line 3 Status:"));
$("#mtalinstatmess5").text($.i18n("Line 4 Status:"));
$("#mtalinstatmess6").text($.i18n("Line 5 Status:"));
$("#mtalinstatmess7").text($.i18n("Line 6 Status:"));
$("#mtalinstatmess8").text($.i18n("Line 7 Status:"));
$("#mtalinstatmess9").text($.i18n("Line 8 Status:"));
Comment thread
pavankumar464 marked this conversation as resolved.
$("#mtasiplogmess1").text($.i18n("MTA SIP Packet Log"));
$("#mtasiploghead").text($.i18n("Gateway > Connection > MTA >SIP Packet Log"));
$("#mtasiplogtip1").text($.i18n("Information related to the SIP Packet Log."));
Expand Down
Loading
Loading