RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per product in UI for residential gateway by pavankumar464 · Pull Request #119 · rdkcentral/webui

pavankumar464 · 2026-04-29T02:40:38Z

No description provided.

… product in UI for residential gateway

…r residential gateway

Copilot

Pull request overview

This PR updates the XB3 web UI templates to render MTA/voice line details based on the device-reported number of line entries, instead of being hard-coded for only 1–2 lines (targeting residential gateway product variants like XB10).

Changes:

Generate the “Line Number” dropdown options dynamically in voice_quality_metrics.jst.
Render CALLP/QoS per-line table rows dynamically in qos.jst.
Render MTA Line Status per-line rows dynamically in mta_Line_Status.jst.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`source/Styles/xb3/jst/voice_quality_metrics.jst`	Dynamically populates the line-number selector based on `LineTableNumberOfEntries`.
`source/Styles/xb3/jst/qos.jst`	Replaces hard-coded line 1/2 rows with a loop over all line entries.
`source/Styles/xb3/jst/mta_Line_Status.jst`	Replaces hard-coded line 1/2 status blocks with a loop over all line entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… product in UI for residential gateway

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

compares $_GET['line'] (string) against getStr("...LineTableNumberOfEntries") Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…s and numeric line validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/a1f497b4-bc28-469d-acde-49047bf774e4 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+				var $status = getStr("Device.X_CISCO_COM_MTA.LineTable." + $i + ".Status");
+				var $rowClass = ($i % 2 == 0) ? "form-row odd" : "form-row";
+				echo('<div class="' + $rowClass + '">');
+					echo('<span class="readonlyLabel" id="mtalinstatmess' + $i + '">Line ' + $i + ' Status:</span>');


-$("#mtalinmess1").text($.i18n("MTA Line 1 Diagnostics"));
 $("[id^='mtalinmess2']").text($.i18n("Hazardous Potential:"));
-$("#line1hp,#line1hp,#line1femf,#line1rf,#line1roh,#line1re,#line2hp,#line2femf,#line2rf,#line2roh,#line2re").text($.i18n("Not Started"));
+$("[id^='line'][id$='hp'],[id^='line'][id$='femf'],[id^='line'][id$='rf'],[id^='line'][id$='roh'],[id^='line'][id$='re']").text($.i18n("Not Started"));


+	for($key in $_GET) {
+		if ($key.startsWith("get_status")) {
+			$line = $key.slice("get_status".length);
+			$action = "get_status";
+		} else if ($key.startsWith("start_diagnostics")) {


+	if ($line !== null && $action !== null) {
+
+		/* ===== GET STATUS ===== */
+		if ($action == "get_status") {
+
+			$linehook = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".Status");
+			sleep(2);
+
+			$arConfig = {
+				["line" + $line + "hook"]: $linehook
+			}/*p2j-array*/;
+		}
+
+		/* ===== START DIAGNOSTICS ===== */
+		else if ($action == "start_diagnostics") {
+
+			setStr(
+				"Device.X_CISCO_COM_MTA.LineTable."+$line+".TriggerDiagnostics",
+				"true",
+				true
+			);


pavankumar464 · 2026-05-08T02:35:13Z

+			$linehook = getStr("Device.X_CISCO_COM_MTA.LineTable."+$line+".Status");
+			sleep(2);
+
+			$arConfig = {
+				["line" + $line + "hook"]: $linehook
+			}/*p2j-array*/;
+		}


@copilot apply changes based on this feedback

Already applied in commit d2047b6. Both the get_status response (line 65) and start_diagnostics response (lines 81–85) now use ES5 bracket assignment ($arConfig["line"+$line+"hook"] = $linehook) instead of ES6 computed property name object literals.

+	$("[id^='start_diagnostics']").on("click", function () {
+		const line = this.id.replace("start_diagnostics", ""); // 1–8
+
+		if (line < 1 || line > 8) return;


pavankumar464 · 2026-05-08T02:34:18Z

+			$arConfig = {
+				["line"+$line+"hp"]   : $hp,
+				["line"+$line+"femf"] : $femf,
+				["line"+$line+"rf"]   : $rf,
+				["line"+$line+"roh"]  : $roh,
+				["line"+$line+"re"]   : $re
+			}; /*p2j-array*/


@copilot apply changes based on this feedback

Applied in commit d2047b6. All ES6 computed property names replaced with ES5 bracket assignment ($arConfig["line"+$line+"hp"] = ...), and the for($key in $_GET) + startsWith() pattern replaced with an explicit isset() loop over line indices that is fully ES5-compatible. Additional related fixes in the same commit: hard-coded > 8 guard in mta_Line_Diagnostics.jst replaced with server-rendered voiceLines, duplicate mtalinstatmess1 ID in mta_Line_Status.jst fixed with +1 offset, .text() changed to .val() for textareas in locale/global.js, and integer-only regex validation added to voice_quality_metrics.jst.

…d int validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/e3dfd3e0-6ed8-4baf-bbea-fda32f9bcbb3 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>

pavankumar464 added 2 commits April 20, 2026 07:53

RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per…

875fa43

… product in UI for residential gateway

RDKB-64534 MTA Line details needs to be fixed as per product in UI fo…

3031959

…r residential gateway

Copilot AI review requested due to automatic review settings April 29, 2026 02:40

pavankumar464 requested review from a team as code owners April 29, 2026 02:40

Merge branch 'develop' into bug/RDKB-64534

b7ac68d

Copilot started reviewing on behalf of pavankumar464 April 29, 2026 02:41 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread source/Styles/xb3/jst/qos.jst Outdated

Comment thread source/Styles/xb3/jst/qos.jst Outdated

Comment thread source/Styles/xb3/jst/mta_Line_Status.jst Outdated

Comment thread source/Styles/xb3/jst/voice_quality_metrics.jst

pavankumar464 added 2 commits May 4, 2026 10:40

RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per…

b91d442

… product in UI for residential gateway

RDKB-64534 mta_Line_Diagnostics.jst

e7303dd

Copilot AI review requested due to automatic review settings May 5, 2026 04:57

Copilot started reviewing on behalf of pavankumar464 May 5, 2026 04:57 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Copilot started work on behalf of pavankumar464 May 5, 2026 05:05 View session

Potential fix for pull request finding

3c47975

compares $_GET['line'] (string) against getStr("...LineTableNumberOfEntries") Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 5, 2026 05:07

Potential fix for pull request finding

99b6cb2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of pavankumar464 May 5, 2026 05:07 View session

RDKB-64534 Fix voice_quality_metrics.jst: dynamic msg_no_data element…

702632f

…s and numeric line validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/a1f497b4-bc28-469d-acde-49047bf774e4 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>

Copilot finished work on behalf of pavankumar464 May 5, 2026 05:08

Copilot AI reviewed May 5, 2026

View reviewed changes

Potential fix for pull request finding

f3834b7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 5, 2026 08:54

Copilot started reviewing on behalf of pavankumar464 May 5, 2026 08:55 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Copilot started work on behalf of pavankumar464 May 8, 2026 02:34 View session

RDKB-64534 Fix ES6 compat, ID collision, textarea val, line guard, an…

d2047b6

…d int validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/e3dfd3e0-6ed8-4baf-bbea-fda32f9bcbb3 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>

Copilot finished work on behalf of pavankumar464 May 8, 2026 02:40

Copilot started work on behalf of pavankumar464 May 8, 2026 02:40 View session

Copilot finished work on behalf of pavankumar464 May 8, 2026 02:41

Conversation

pavankumar464 commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pavankumar464 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2026

Choose a reason for hiding this comment

Uh oh!

pavankumar464 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants