Skip to content

RDKB-62889: Reduce Repetitive logging #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suriya-prem wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKB-62889: Reduce Repetitive logging #300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31e76a8
RDKB-62889: Reduce Repetitive logging0
May 5, 2026
6a0ba5b
Update firewall.c
suriya-prem May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions source/firewall/firewall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,6 @@ void firewall_log( char* fmt, ...)
#ifdef WAN_FAILOVER_SUPPORTED
unsigned int Get_Device_Mode()
{
FIREWALL_DEBUG("Inside Get_Device_Mode\n");
syscfg_get(NULL, "Device_Mode", dev_type, sizeof(dev_type));
unsigned int dev_mode = atoi(dev_type);
Dev_Mode mode;
Expand Down Expand Up @@ -926,7 +925,6 @@ char* get_iface_ipaddr(const char* iface_name)

bool isServiceNeeded()
{
FIREWALL_DEBUG("Inside isServiceNeeded\n");
if (Get_Device_Mode()==EXTENDER_MODE)
{
FIREWALL_DEBUG("Service Not Needed\n");
Expand All @@ -945,7 +943,6 @@ bool isServiceNeeded()
}
}

FIREWALL_DEBUG("returning true\n");
return TRUE;
}
#endif
Expand Down Expand Up @@ -3313,7 +3310,6 @@ int do_single_port_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *f
FIREWALL_DEBUG("Entering do_single_port_forwarding\n");
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
BOOL isBothProtocol = FALSE;
BOOL isFeatureDisabled = TRUE;
#endif
query[0] = '\0';
rc = syscfg_get(NULL, "SinglePortForwardCount", query, sizeof(query));
Expand All @@ -3328,12 +3324,6 @@ int do_single_port_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *f
count = MAX_SYSCFG_ENTRIES;
}
}
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
Comment thread
aadhithan01 marked this conversation as resolved.
{
FIREWALL_DEBUG("PortMapping:Feature Enable %d\n" COMMA TRUE);
isFeatureDisabled = FALSE;
}
#endif

for (idx=1 ; idx<=count ; idx++) {
namespace[0] = '\0';
Expand Down Expand Up @@ -3685,12 +3675,6 @@ int do_single_port_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *f
#endif
}
SinglePortForwardNext:
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
if(isFeatureDisabled == TRUE)
{
FIREWALL_DEBUG("PortMapping:Feature Enable %d\n" COMMA FALSE);
}
#endif
FIREWALL_DEBUG("Exiting do_single_port_forwarding\n");
return(0);
}
Expand All @@ -3714,7 +3698,6 @@ int do_port_range_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *fi
int count;
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
BOOL isBothProtocol = FALSE;
BOOL isFeatureDisabled = TRUE;
#endif

#ifdef CISCO_CONFIG_TRUE_STATIC_IP
Expand All @@ -3735,10 +3718,6 @@ int do_port_range_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *fi
count = MAX_SYSCFG_ENTRIES;
}
}
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
FIREWALL_DEBUG("PortMapping:Feature Enable %d\n" COMMA TRUE);
isFeatureDisabled = FALSE;
#endif

for (idx=1 ; idx<=count ; idx++) {
namespace[0] = '\0';
Expand Down Expand Up @@ -4142,13 +4121,6 @@ int do_port_range_forwarding(FILE *nat_fp, FILE *filter_fp, int iptype, FILE *fi

}
PortRangeForwardNext:
#if defined (FEATURE_MAPT) || defined (FEATURE_SUPPORT_MAPT_NAT46)
if (isFeatureDisabled == TRUE)
{
FIREWALL_DEBUG("PortMapping:Feature Enable %d\n" COMMA FALSE);
Comment thread
aadhithan01 marked this conversation as resolved.
}
#endif

FIREWALL_DEBUG("Exiting do_port_range_forwarding\n");

return(0);
Expand Down Expand Up @@ -6343,7 +6315,6 @@ static int remote_access_set_proto(FILE *filt_fp, FILE *nat_fp, const char *port
char httpsport[64] = {0};
char tmpQuery[MAX_QUERY];

FIREWALL_DEBUG("Entering remote_access_set_proto\n");
ret = syscfg_get(NULL, "mgmt_wan_httpport", httpport, sizeof(port));
#if defined(CONFIG_CCSP_WAN_MGMT_PORT)
tmpQuery[0] = '\0';
Expand Down Expand Up @@ -6384,7 +6355,6 @@ static int remote_access_set_proto(FILE *filt_fp, FILE *nat_fp, const char *port
fprintf(filt_fp, "-A INPUT -i %s %s -p tcp -m tcp --dport %s -j ACCEPT\n", interface, src, port);
}
}
FIREWALL_DEBUG("Exiting remote_access_set_proto\n");
return 0;
}
int wan_lan_webui_attack(FILE *fp, const char *interface)
Expand Down
Loading