RDKB-62889: Reduce Repetitive logging

[suriya-prem]

RDKB-62889: Reduce Repetitive logging

Reason for change: Remove unwanted logs.
Test Procedure: Check firewall debug log file
Risks: Low
Priority: P1
Signed-off-by: Suriyanarayanan_MP@comcast.com

[Copilot]

Pull request overview

This PR (RDKB-62889) reduces repetitive firewall debug logging by removing several “enter/exit/inside” FIREWALL_DEBUG statements and a couple of MAPT-related debug blocks in port-forwarding paths.

Changes:

• Removed redundant FIREWALL_DEBUG messages from WAN failover helper functions.
• Removed MAPT “feature enable” debug blocks (and related flag usage) from single/range port forwarding code paths.
• Removed “Entering/Exiting” debug logs in remote_access_set_proto().

Comments suppressed due to low confidence (1)

source/firewall/firewall.c:6324

• Potential buffer handling bugs: syscfg_get is called with sizeof(port) (port is a pointer parameter), so it will only read a pointer-sized amount into httpport rather than the full buffer. Also, under CONFIG_CCSP_WAN_MGMT_PORT, strcpy(httpport, tmpQuery) can overflow httpport (64) because tmpQuery is MAX_QUERY (256). Use the destination buffer size for syscfg_get and a bounded copy (and ideally validate the port string length/content) before storing into httpport.

        ret = syscfg_get(NULL, "mgmt_wan_httpport", httpport, sizeof(port));
#if defined(CONFIG_CCSP_WAN_MGMT_PORT)
          tmpQuery[0] = '\0';
          ret = syscfg_get(NULL, "mgmt_wan_httpport_ert", tmpQuery, sizeof(tmpQuery));
          if(ret == 0)
              strcpy(httpport, tmpQuery);
#endif

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.