Read more / read less inline variant#38
Merged
Merged
Conversation
Contributor
|
I don't think we want a different variant. I think we want to have one component that allows you to overwrite the buttons to use and place them where you need them to be. I also don't think you need that group-peer plugin since we have group-has? Question is since you are changing the structure. isn't it maybe easier to make this fully javascript or still have the peer-checked and js combination. |
jordythevulder
requested changes
Mar 30, 2026
Contributor
jordythevulder
left a comment
jordythevulder
left a comment
There was a problem hiding this comment.
See my other comment
royduin
reviewed
May 1, 2026
…ture/readmore-less-variant
…ade-components into feature/readmore-less-variant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current
readmorecomponent this was not possible:I have added a new variant that you can use to make it like the example above:
Because of the difference in the structure I decided to make a new variant instead of changing the current component.