Read more / read less inline variant#40
Closed
Roene-JustBetter wants to merge 6 commits into
Closed
Conversation
…idez/blade-components into feature/readmore-less-variant-inline
| ## Notes | ||
| - **Clamping** The default of line-clamp-5 is used. | ||
| - **Buttons** You can't use <button tags inside the slots because it's wrapped by a <label. Simply use a <span tag. | ||
| - **Buttons** You can't use <button> tags inside the slots because it's wrapped by a <label>. Simply use a <span> tag. |
Contributor
There was a problem hiding this comment.
This isn't true anymore, in this PR you have removed the label btw
Member
|
Closing in favor of #38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a variant for: #38
Made use of JavaScript to show and hide the more / less buttons instead of a separate variant.
Let's see what everyone prefer so we could merge this Pull request or: #38