Skip to content

[NA] Fix DeclareEnumLaunchArgument for string enums #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhidalgo-rai merged 1 commit into from
Mar 30, 2026
Merged

[NA] Fix DeclareEnumLaunchArgument for string enums #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions synchros2/synchros2/launch/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,23 +60,23 @@ def __init__(self, enum_type: Type[Enum], *args: Any, optional: bool = False, **
raise KeyError("Cannot set `choices` for `DeclareEnumLaunchArgument`")
if "default_value" in kwargs:
default_value = kwargs["default_value"]
if isinstance(default_value, str):
if default_value not in choices:
if isinstance(default_value, enum_type):
if default_value not in enum_type:
raise ValueError(
(
f"For an Enum Launch Argument of type {enum_type.__name__}, the `default_value` must be"
f" from {choices} or {list(enum_type)}"
),
)
elif isinstance(default_value, enum_type):
if default_value not in enum_type:
kwargs["default_value"] = str(default_value.value)
elif isinstance(default_value, str):
if default_value not in choices:
raise ValueError(
(
f"For an Enum Launch Argument of type {enum_type.__name__}, the `default_value` must be"
f" from {choices} or {list(enum_type)}"
),
)
kwargs["default_value"] = str(default_value.value)
else:
raise TypeError(
(
Expand Down
Loading