[NA] Fix DeclareEnumLaunchArgument for string enums#199
Merged
Conversation
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
mhidalgo-rai
requested review from
khughes-bdai and
tcappellari-bdai
as code owners
Collaborator
Author
|
Hmm, I suspect we need #198 in. CI's crashing hard. |
tcappellari-bdai
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Precisely what the title says. When using an
enumtype that is also astr, the wrong conditional was getting picked up first.Checklist
Additional comments
Interestingly enough, there was already a test for this. That is how I caught this (see #198). Not sure how this didn't come up before.