Skip to content

Exclude StorageBuffer from device.buffers tracking #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slimbuck merged 2 commits into from
May 6, 2026
Merged

Exclude StorageBuffer from device.buffers tracking #8690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7047ffc
latest
slimbuck May 6, 2026
bf9b1bd
latest
slimbuck May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/platform/graphics/storage-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ class StorageBuffer {
const usage = addStorageUsage ? (BUFFERUSAGE_STORAGE | bufferUsage) : bufferUsage;
this.impl = graphicsDevice.createBufferImpl(usage);
this.impl.allocate(graphicsDevice, byteSize);
this.device.buffers.add(this);

// Note: not registered in device.buffers — storage buffer contents are not
// recoverable on device-lost (no CPU-side shadow, may be GPU-written), so
// they don't participate in the engine's auto lose/restore iteration.
// Consumers handling device-lost must destroy() and recreate storage buffers.
Comment thread
slimbuck marked this conversation as resolved.

this.adjustVramSizeTracking(graphicsDevice._vram, this.byteSize);
}
Expand All @@ -47,13 +51,8 @@ class StorageBuffer {
* Frees resources associated with this storage buffer.
*/
destroy() {

// stop tracking the buffer
const device = this.device;
device.buffers.delete(this);

this.adjustVramSizeTracking(device._vram, -this.byteSize);
this.impl.destroy(device);
this.adjustVramSizeTracking(this.device._vram, -this.byteSize);
this.impl.destroy(this.device);
}

adjustVramSizeTracking(vram, size) {
Expand Down