Exclude StorageBuffer from device.buffers tracking#8690
Merged
slimbuck merged 2 commits intoplaycanvas:mainfrom May 6, 2026
Merged
Exclude StorageBuffer from device.buffers tracking#8690slimbuck merged 2 commits intoplaycanvas:mainfrom
slimbuck merged 2 commits intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a WebGPU device-lost crash caused by StorageBuffer being tracked in GraphicsDevice.buffers without implementing the loseContext() method that GraphicsDevice.loseContext() expects to call for all tracked buffers.
Changes:
- Add
StorageBuffer.loseContext()to forward device-lost handling to the underlying implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvaligursky
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorageBufferregisters itself inGraphicsDevice.buffersbut does not implement eitherloseContext()orunlock(), which causes a WebGPU device-lost flow to throw on iteration: