Skip to content

feat: add componentConfig and annotations API types (EP#1898)#126

Open
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.0from
swghosh:feature/api-types-1898-63542
Open

feat: add componentConfig and annotations API types (EP#1898)#126
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.0from
swghosh:feature/api-types-1898-63542

Conversation

@swghosh
Copy link
Copy Markdown
Member

@swghosh swghosh commented Apr 6, 2026

Summary

  • Extends ExternalSecretsConfig API with annotations and componentConfigs fields on ControllerConfig as specified in Enhancement Proposal #1898
  • Adds new types: ComponentConfig, DeploymentConfig, Annotation
  • Adds new ComponentName enum values: Webhook, CertController
  • Includes CEL validation rules for reserved annotation prefixes (kubernetes.io/, app.kubernetes.io/, openshift.io/, k8s.io/) and reserved environment variable prefixes (HOSTNAME, KUBERNETES_, EXTERNAL_SECRETS_)
  • Adds comprehensive integration test coverage for all new fields and validation rules
  • Regenerated deepcopy functions and CRD manifests

Test plan

  • Integration tests pass for all new onCreate and onUpdate test cases
  • Verify CRD manifest includes new fields with proper validation schemas
  • Verify reserved annotation/env var prefix rejection via CEL rules
  • Verify componentName enum validation (ExternalSecretsCoreController, Webhook, CertController, BitwardenSDKServer)
  • Verify revisionHistoryLimit minimum constraint (>=1)
  • Verify maxItems=4 constraint on componentConfigs

🤖 Generated with Claude Code

…sConfig

Extend the ExternalSecretsConfig API with componentConfig and annotations
fields as specified in enhancement proposal #1898 (ESO-266).

New types added:
- ComponentConfig: per-component deployment overrides and env vars
- DeploymentConfig: deployment-level settings (revisionHistoryLimit)
- Annotation: custom annotation key-value pairs

New ComponentName enum values: Webhook, CertController

Includes CEL validation for reserved annotation prefixes and env var names,
integration test suite coverage, regenerated deepcopy and CRD manifests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6eebdddf-782c-40af-a2eb-852612a044b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from TrilokGeer and mytreya-rh April 6, 2026 08:21
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant