feat: add e2e test artifacts for componentConfig and annotations (EP#1898)#129
Open
swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.0from
Open
feat: add e2e test artifacts for componentConfig and annotations (EP#1898)#129swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.0from
swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.0from
Conversation
…sConfig Extend the ExternalSecretsConfig API with componentConfig and annotations fields as specified in enhancement proposal #1898 (ESO-266). New types added: - ComponentConfig: per-component deployment overrides and env vars - DeploymentConfig: deployment-level settings (revisionHistoryLimit) - Annotation: custom annotation key-value pairs New ComponentName enum values: Webhook, CertController Includes CEL validation for reserved annotation prefixes and env var names, integration test suite coverage, regenerated deepcopy and CRD manifests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add controller reconciliation logic for the componentConfig and annotations API fields introduced in EP #1898: - applyAnnotationsToDeployment: applies custom annotations (with reserved prefix filtering) to deployment and pod template metadata - applyComponentConfigToDeployment: applies per-component overrides including revisionHistoryLimit and overrideEnv to target deployments - Maps ComponentName enum values to deployment assets and container names Integrates with existing getDeploymentObject pipeline so all deployment reconciliation flows (create and update) apply the new configuration. Includes comprehensive unit tests for all new functions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…1898) Generate e2e test artifacts for the componentConfig and annotations feature introduced in EP #1898: - test-cases.md: 10 test scenarios covering annotations, componentConfigs, revisionHistoryLimit, overrideEnv, and validation constraints - execution-steps.md: step-by-step oc commands for manual execution - e2e_component_config_test.go: Ginkgo e2e tests matching existing patterns (dynamic client, Eventually assertions, waitForESCReady helper) - e2e-suggestions.md: prioritized scenario recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
occommands for manual e2e validationDepends on
Test plan
e2e_component_config_test.gototest/e2e/directory🤖 Generated with Claude Code