Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/openshift-online/ocm-cli

go 1.24.13
go 1.25.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify all pinned Go versions across repo are aligned with go.mod (1.25.x)
set -euo pipefail

echo "== go.mod/go.work directives =="
rg -n --type=gomod '^\s*go\s+1\.' go.mod go.work 2>/dev/null || true

echo
echo "== CI and container Go version pins =="
rg -n -C2 --iglob '*.{yml,yaml}' --iglob 'Dockerfile*' --iglob '*.mk' \
  'go-version:|golang:1\.|GO_VERSION|GOLANG_VERSION|setup-go|actions/setup-go'

echo
echo "Expected: all pins reference 1.25.x (or are unpinned and inherit toolchain safely)."

Repository: openshift-online/ocm-cli

Length of output: 139


🏁 Script executed:

# Check go.mod exists and read it directly
echo "=== go.mod content ===" 
cat go.mod | head -20

# Find all CI/build configuration files
echo -e "\n=== CI and build config files ===" 
fd -e yml -e yaml -e mk -t f | grep -E '(\.github|\.gitlab|workflow|dockerfile|compose|build)' -i

Repository: openshift-online/ocm-cli

Length of output: 771


🏁 Script executed:

# Check for .github/workflows directory specifically
echo "=== .github directory contents ===" 
ls -la .github/ 2>/dev/null || echo "No .github directory"

# Search for any Dockerfile
echo -e "\n=== Any Dockerfile files ===" 
find . -name "Dockerfile*" -o -name "*dockerfile*" 2>/dev/null | head -20

# List root directory to understand repo structure
echo -e "\n=== Root directory ===" 
ls -la | grep -E '^d|\.yml|\.yaml|Makefile'

# Check if there's a go.work file
echo -e "\n=== go.work file ===" 
cat go.work 2>/dev/null || echo "No go.work file"

Repository: openshift-online/ocm-cli

Length of output: 1195


🏁 Script executed:

# Check GitHub workflows for Go version pins
echo "=== .github/workflows files ===" 
ls -la .github/workflows/
echo
for file in .github/workflows/*.yml .github/workflows/*.yaml; do
  [ -f "$file" ] && echo "--- $file ---" && cat "$file"
done

# Check Dockerfile
echo -e "\n=== docker/Dockerfile ===" 
cat docker/Dockerfile

# Check Makefile for Go version
echo -e "\n=== Makefile (Go version related) ===" 
grep -n -i 'go.*version\|golang' Makefile || echo "No explicit Go version in Makefile"

# Check .tekton for Go version
echo -e "\n=== .tekton files ===" 
find .tekton -type f | xargs cat 2>/dev/null || echo "No .tekton config files"

Repository: openshift-online/ocm-cli

Length of output: 47016


Update GitHub Actions workflows to use Go 1.25.x before merging.

The go.mod bump to Go 1.25.0 will fail CI because workflows pin older versions:

  • .github/workflows/check-pull-request.yaml: test job uses 1.22, lint job uses 1.23
  • .github/workflows/publish-release.yaml: release job uses 1.23

Update all go-version fields to 1.25.x in both workflow files. The Docker and Tekton builds use ubi9/go-toolset:latest, which may inherit the correct toolchain but should also be reviewed for consistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 3, Update the GitHub Actions workflow Go versions so CI
matches the bumped go.mod: edit .github/workflows/check-pull-request.yaml and
.github/workflows/publish-release.yaml and change all go-version fields that are
pinned to older Go (e.g., 1.22 and 1.23) to "1.25.x"; also review any
Docker/Tekton references (ubi9/go-toolset:latest) for consistency but the
immediate fix is updating the go-version keys in the two workflow files so they
use 1.25.x.


require (
cloud.google.com/go/iam v1.5.3
Expand All @@ -9,7 +9,7 @@ require (
github.com/MicahParks/jwkset v0.11.0
github.com/golang-jwt/jwt/v4 v4.5.2
github.com/golang/glog v1.2.5
github.com/googleapis/gax-go/v2 v2.16.0
github.com/googleapis/gax-go/v2 v2.20.0
github.com/hashicorp/go-version v1.8.0
github.com/m1/go-generate-password v0.2.0
github.com/mitchellh/go-homedir v1.1.0
Expand All @@ -25,10 +25,10 @@ require (
github.com/spf13/pflag v1.0.10
gitlab.com/c0b/go-ordered-json v0.0.0-20201030195603-febf46534d5a
go.uber.org/mock v0.6.0
golang.org/x/term v0.39.0
golang.org/x/text v0.33.0
google.golang.org/api v0.257.0
google.golang.org/grpc v1.77.0
golang.org/x/term v0.41.0
golang.org/x/text v0.35.0
google.golang.org/api v0.272.0
google.golang.org/grpc v1.79.3
gopkg.in/yaml.v3 v3.0.1
k8s.io/apimachinery v0.34.3
)
Expand All @@ -37,7 +37,7 @@ require (
al.essio.dev/pkg/shellescape v1.6.0 // indirect
cel.dev/expr v0.25.1 // indirect
cloud.google.com/go v0.123.0 // indirect
cloud.google.com/go/auth v0.18.0 // indirect
cloud.google.com/go/auth v0.18.2 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect
cloud.google.com/go/compute/metadata v0.9.0 // indirect
cloud.google.com/go/monitoring v1.24.3 // indirect
Expand Down Expand Up @@ -97,7 +97,7 @@ require (
github.com/google/pprof v0.0.0-20251206212654-f1b79c6b8239 // indirect
github.com/google/s2a-go v0.1.9 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.7 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.14 // indirect
github.com/gorilla/css v1.0.1 // indirect
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
Expand Down Expand Up @@ -132,24 +132,24 @@ require (
go.opentelemetry.io/contrib/detectors/gcp v1.39.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.64.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.64.0 // indirect
go.opentelemetry.io/otel v1.39.0 // indirect
go.opentelemetry.io/otel/metric v1.39.0 // indirect
go.opentelemetry.io/otel/sdk v1.39.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.39.0 // indirect
go.opentelemetry.io/otel/trace v1.39.0 // indirect
go.opentelemetry.io/otel v1.42.0 // indirect
go.opentelemetry.io/otel/metric v1.42.0 // indirect
go.opentelemetry.io/otel/sdk v1.42.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.42.0 // indirect
go.opentelemetry.io/otel/trace v1.42.0 // indirect
go.yaml.in/yaml/v2 v2.4.3 // indirect
go.yaml.in/yaml/v3 v3.0.4 // indirect
golang.org/x/crypto v0.47.0 // indirect
golang.org/x/mod v0.32.0 // indirect
golang.org/x/net v0.49.0 // indirect
golang.org/x/oauth2 v0.34.0 // indirect
golang.org/x/sync v0.19.0 // indirect
golang.org/x/sys v0.40.0 // indirect
golang.org/x/time v0.14.0 // indirect
golang.org/x/tools v0.41.0 // indirect
google.golang.org/genproto v0.0.0-20251213004720-97cd9d5aeac2 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20251213004720-97cd9d5aeac2 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20251213004720-97cd9d5aeac2 // indirect
golang.org/x/crypto v0.49.0 // indirect
golang.org/x/mod v0.33.0 // indirect
golang.org/x/net v0.52.0 // indirect
golang.org/x/oauth2 v0.36.0 // indirect
golang.org/x/sync v0.20.0 // indirect
golang.org/x/sys v0.42.0 // indirect
golang.org/x/time v0.15.0 // indirect
golang.org/x/tools v0.42.0 // indirect
google.golang.org/genproto v0.0.0-20260319201613-d00831a3d3e7 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260319201613-d00831a3d3e7 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260319201613-d00831a3d3e7 // indirect
google.golang.org/protobuf v1.36.11 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
k8s.io/klog/v2 v2.130.1 // indirect
Expand Down
Loading
Loading