Build(deps): Bump github.com/googleapis/gax-go/v2 from 2.16.0 to 2.20.0#1064
Build(deps): Bump github.com/googleapis/gax-go/v2 from 2.16.0 to 2.20.0#1064dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [github.com/googleapis/gax-go/v2](https://github.com/googleapis/gax-go) from 2.16.0 to 2.20.0. - [Release notes](https://github.com/googleapis/gax-go/releases) - [Commits](googleapis/gax-go@v2.16.0...v2.20.0) --- updated-dependencies: - dependency-name: github.com/googleapis/gax-go/v2 dependency-version: 2.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
WalkthroughGo toolchain updated from 1.24.13 to 1.25.0. Direct dependencies bumped including gax-go/v2, golang.org/x modules (term, text), and google.golang.org packages (api, grpc). Indirect dependencies advanced across cloud.google.com/go/auth, enterprise-certificate-proxy, OpenTelemetry modules, and genproto. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
go.mod (1)
12-12: Harden APIError extraction for wrapped errors with this gax-go/v2 and grpc upgrades.The three handler functions in
pkg/gcp/error_handlers.go(lines 13, 24, 32) use direct type assertions to extract*apierror.APIError. This pattern fails silently on wrapped error chains. Useerrors.As()instead—the file already demonstrates this pattern correctly at line 45 forgoogleapi.Error.Suggested refactor pattern
- pApiError, ok := err.(*apierror.APIError) - if !ok { + var pApiError *apierror.APIError + if !errors.As(err, &pApiError) { return fmt.Errorf("Unexpected error") }Apply the same pattern to
fmtGoogleApiError()at line 50 for consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 12, The handlers in pkg/gcp/error_handlers.go currently use direct type assertions to extract *apierror.APIError (the three handler functions around the top of the file) which fails on wrapped error chains; change those assertions to use errors.As to walk the chain and extract the *apierror.APIError (e.g., use var apiErr *apierror.APIError; if errors.As(err, &apiErr) { ... }); apply the same pattern to fmtGoogleApiError() so it also uses errors.As instead of a direct type assertion; keep existing logging/handling logic but guard it behind the errors.As check and handle the non-matching case as before.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflow Go versions so CI matches the
bumped go.mod: edit .github/workflows/check-pull-request.yaml and
.github/workflows/publish-release.yaml and change all go-version fields that are
pinned to older Go (e.g., 1.22 and 1.23) to "1.25.x"; also review any
Docker/Tekton references (ubi9/go-toolset:latest) for consistency but the
immediate fix is updating the go-version keys in the two workflow files so they
use 1.25.x.
---
Nitpick comments:
In `@go.mod`:
- Line 12: The handlers in pkg/gcp/error_handlers.go currently use direct type
assertions to extract *apierror.APIError (the three handler functions around the
top of the file) which fails on wrapped error chains; change those assertions to
use errors.As to walk the chain and extract the *apierror.APIError (e.g., use
var apiErr *apierror.APIError; if errors.As(err, &apiErr) { ... }); apply the
same pattern to fmtGoogleApiError() so it also uses errors.As instead of a
direct type assertion; keep existing logging/handling logic but guard it behind
the errors.As check and handle the non-matching case as before.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2cbaa595-970c-4b6d-a4ee-df90d4e26af0
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all pinned Go versions across repo are aligned with go.mod (1.25.x)
set -euo pipefail
echo "== go.mod/go.work directives =="
rg -n --type=gomod '^\s*go\s+1\.' go.mod go.work 2>/dev/null || true
echo
echo "== CI and container Go version pins =="
rg -n -C2 --iglob '*.{yml,yaml}' --iglob 'Dockerfile*' --iglob '*.mk' \
'go-version:|golang:1\.|GO_VERSION|GOLANG_VERSION|setup-go|actions/setup-go'
echo
echo "Expected: all pins reference 1.25.x (or are unpinned and inherit toolchain safely)."Repository: openshift-online/ocm-cli
Length of output: 139
🏁 Script executed:
# Check go.mod exists and read it directly
echo "=== go.mod content ==="
cat go.mod | head -20
# Find all CI/build configuration files
echo -e "\n=== CI and build config files ==="
fd -e yml -e yaml -e mk -t f | grep -E '(\.github|\.gitlab|workflow|dockerfile|compose|build)' -iRepository: openshift-online/ocm-cli
Length of output: 771
🏁 Script executed:
# Check for .github/workflows directory specifically
echo "=== .github directory contents ==="
ls -la .github/ 2>/dev/null || echo "No .github directory"
# Search for any Dockerfile
echo -e "\n=== Any Dockerfile files ==="
find . -name "Dockerfile*" -o -name "*dockerfile*" 2>/dev/null | head -20
# List root directory to understand repo structure
echo -e "\n=== Root directory ==="
ls -la | grep -E '^d|\.yml|\.yaml|Makefile'
# Check if there's a go.work file
echo -e "\n=== go.work file ==="
cat go.work 2>/dev/null || echo "No go.work file"Repository: openshift-online/ocm-cli
Length of output: 1195
🏁 Script executed:
# Check GitHub workflows for Go version pins
echo "=== .github/workflows files ==="
ls -la .github/workflows/
echo
for file in .github/workflows/*.yml .github/workflows/*.yaml; do
[ -f "$file" ] && echo "--- $file ---" && cat "$file"
done
# Check Dockerfile
echo -e "\n=== docker/Dockerfile ==="
cat docker/Dockerfile
# Check Makefile for Go version
echo -e "\n=== Makefile (Go version related) ==="
grep -n -i 'go.*version\|golang' Makefile || echo "No explicit Go version in Makefile"
# Check .tekton for Go version
echo -e "\n=== .tekton files ==="
find .tekton -type f | xargs cat 2>/dev/null || echo "No .tekton config files"Repository: openshift-online/ocm-cli
Length of output: 47016
Update GitHub Actions workflows to use Go 1.25.x before merging.
The go.mod bump to Go 1.25.0 will fail CI because workflows pin older versions:
.github/workflows/check-pull-request.yaml: test job uses1.22, lint job uses1.23.github/workflows/publish-release.yaml: release job uses1.23
Update all go-version fields to 1.25.x in both workflow files. The Docker and Tekton builds use ubi9/go-toolset:latest, which may inherit the correct toolchain but should also be reviewed for consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, Update the GitHub Actions workflow Go versions so CI
matches the bumped go.mod: edit .github/workflows/check-pull-request.yaml and
.github/workflows/publish-release.yaml and change all go-version fields that are
pinned to older Go (e.g., 1.22 and 1.23) to "1.25.x"; also review any
Docker/Tekton references (ubi9/go-toolset:latest) for consistency but the
immediate fix is updating the go-version keys in the two workflow files so they
use 1.25.x.
Bumps github.com/googleapis/gax-go/v2 from 2.16.0 to 2.20.0.
Release notes
Sourced from github.com/googleapis/gax-go/v2's releases.
Commits
25485abchore: create a release (#495)1f3e9aefeat: hook metric recording into gax.Invoke (#494)defddedfeat(v2): add TelemetryErrorInfo and ExtractTelemetryErrorInfo (#487)399c197chore(all): update all (#492)c64aabechore(all): update module google.golang.org/grpc to v1.79.3 [SECURITY] (#490)06bdf7fchore: create a release (#486)bf56424chore(all): update all (#484)fb6c5f4fix(v2): lazy initialization and getters for ClientMetrics (#485)336f424build: run linters on all submodules and fix deprecations (#483)a46b2dechore(v2): Improve docs surrounding TransportTelemetryData (#482)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)