Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deps/uv/uv.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@
'-Wall',
'-Wextra',
'-Wno-unused-parameter',
# `uv_cpu_info_t.model` is exposed as `const char*`, but libuv frees
# the owned buffer internally via `uv__free(void*)`.
'-Wno-incompatible-pointer-types-discards-qualifiers',
'-Wstrict-prototypes',
],
'OTHER_CFLAGS': [ '-g', '--std=gnu11' ],
Expand Down
13 changes: 11 additions & 2 deletions tools/gyp/pylib/gyp/mac_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,14 @@ def ExecFlock(self, lockfile, *cmd_list):
def ExecFilterLibtool(self, *cmd_list):
"""Calls libtool and filters out '/path/to/libtool: file: foo.o has no
symbols'."""
libtool_re = re.compile(
libtool_no_symbols_re = re.compile(
r"^.*libtool: (?:for architecture: \S* )?file: .* has no symbols$"
)
# Newer Apple cctools emits the same warning as:
# libtool: warning: 'foo.o' has no symbols
libtool_no_symbols_warning_re = re.compile(
r"^.*libtool: warning: '.*' has no symbols$"
)
libtool_re5 = re.compile(
r"^.*libtool: warning for library: "
+ r".* the table of contents is empty "
Expand All @@ -271,7 +276,11 @@ def ExecFilterLibtool(self, *cmd_list):
libtoolout = subprocess.Popen(cmd_list, stderr=subprocess.PIPE, env=env)
err = libtoolout.communicate()[1].decode("utf-8")
for line in err.splitlines():
if not libtool_re.match(line) and not libtool_re5.match(line):
if (
not libtool_no_symbols_re.match(line)
and not libtool_no_symbols_warning_re.match(line)
and not libtool_re5.match(line)
):
print(line, file=sys.stderr)
# Unconditionally touch the output .a file on the command line if present
# and the command succeeded. A bit hacky.
Expand Down
3 changes: 3 additions & 0 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -2421,6 +2421,9 @@
],
},
'include_dirs': ['.'],
# Keep the GYP target aligned with third_party/simdutf/BUILD.gn, which
# suppresses this warning for the amalgamated translation unit.
'cflags_cc': [ '-Wno-unused-function' ],
'sources': [
'<(V8_ROOT)/third_party/simdutf/simdutf.cpp',
],
Expand Down
Loading