Skip to content

add several build flags to avoid unnecessary warnings#62563

Open
anonrig wants to merge 3 commits intonodejs:mainfrom
anonrig:yagiz/improve-build-warnings-macos
Open

add several build flags to avoid unnecessary warnings#62563
anonrig wants to merge 3 commits intonodejs:mainfrom
anonrig:yagiz/improve-build-warnings-macos

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Apr 2, 2026

Whenever I build Node.js on my macOS machine, I always see this unnecessary warnings. Since they're dependencies, we can just ignore warnings.

cc @nodejs/build

@anonrig anonrig requested a review from targos April 2, 2026 16:35
@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Apr 2, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 2, 2026
@anonrig anonrig requested a review from jasnell April 2, 2026 16:53
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (a9ac9b1) to head (56b1444).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62563      +/-   ##
==========================================
- Coverage   89.70%   89.70%   -0.01%     
==========================================
  Files         695      695              
  Lines      214213   214213              
  Branches    41021    41027       +6     
==========================================
- Hits       192167   192155      -12     
+ Misses      14113    14112       -1     
- Partials     7933     7946      +13     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig requested review from Qard, ShogunPanda and lemire April 2, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. gyp Issues and PRs related to the GYP tool and .gyp build files libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants