Skip to content

Updates .mnu files to point to newer (non-deprecated) versions of VIs#154

Merged
shivaprasad-basavaraj merged 4 commits intoni:developfrom
zyah-solutions:hotfix/152_Palette_Fix
Mar 13, 2026
Merged

Updates .mnu files to point to newer (non-deprecated) versions of VIs#154
shivaprasad-basavaraj merged 4 commits intoni:developfrom
zyah-solutions:hotfix/152_Palette_Fix

Conversation

@CaseyZS
Copy link
Copy Markdown
Collaborator

@CaseyZS CaseyZS commented Mar 6, 2026

GitHub Issue for the Pull Request

Link to the relevant GitHub issue

GitHub Discussions Related to this Pull Request

List any GitHub discussion links related to this PR

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

  • I do not require assistance from NI to complete any of the following checks.
  • The changes in this PR are based on the appropriate NI-repo feature branch
  • I am submitting the changes in this PR to the appropriate NI-repo feature branch
  • I built a VI Package using the Powershell build tool.
  • I installed the VI Package produced by the Powershell build tool and tested my change.
  • I tested my changes after installing the VI package.
  • NI has my contributor license agreement.

Summary of Changes

Relinks item in the Actor Framework menus to non-deprecated versions of the VIs.

Reason for Change

2026 Q1 shipped with the old palettes that linked to deprecated versions of Actor Framework VIs.

Visual Aids

Include any visual aids that would help the reviewer gain additional context.

Additional Information

This PR supersedes the PR that @niACS created and does NOT contain the new items in #153. Any additions to the menus that @niACS had made would need to be in a different PR.

Testing

This section describes the automated and manual tests performed for this bugfix/feature.

Manual Tests

I replaced the files in "C:\Program Files\National Instruments\LabVIEW 2026\menus\Categories\Data Communication" with the ones in this PR, relaunched LabVIEW and verified that menus reflected the re-linking.
AF Palette - Main (fixed)
AF Palette - Advanced (fixed)

@CaseyZS CaseyZS marked this pull request as ready for review March 6, 2026 19:35
@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 6, 2026

@shivaprasad-basavaraj @gregr-ni can someone on NI's side verify this fix?

@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 9, 2026

As per @niACS 's comments in #153...

Added controls palette:
image

Added Test Support subpalette:
image
image

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

@CaseyZS This PR still leaves two copies of the mnu files in the repo which is confusing. The original mnu files which are incorrect are directly under the Core folder and the new corrected ones in the new folder structure you created. I would rather move all the mnu files into the new folder strcuture (including _actorframework_msgqueuepair.mnu) and delete the incorrect mnu files directly under Core.

@niACS
Copy link
Copy Markdown
Collaborator

niACS commented Mar 12, 2026

@CaseyZS This PR still leaves two copies of the mnu files in the repo which is confusing. The original mnu files which are incorrect are directly under the Core folder and the new corrected ones in the new folder structure you created. I would rather move all the mnu files into the new folder strcuture (including _actorframework_msgqueuepair.mnu) and delete the incorrect mnu files directly under Core.

This is correct; the two menus directly under Core should be deleted.

@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 12, 2026

@CaseyZS This PR still leaves two copies of the mnu files in the repo which is confusing. The original mnu files which are incorrect are directly under the Core folder and the new corrected ones in the new folder structure you created. I would rather move all the mnu files into the new folder strcuture (including _actorframework_msgqueuepair.mnu) and delete the incorrect mnu files directly under Core.

This is correct; the two menus directly under Core should be deleted.

I can correct this. Are there any functional issues with the menus themselves that I should address at the same time, @shivaprasad-basavaraj ?

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

@CaseyZS This PR still leaves two copies of the mnu files in the repo which is confusing. The original mnu files which are incorrect are directly under the Core folder and the new corrected ones in the new folder structure you created. I would rather move all the mnu files into the new folder strcuture (including _actorframework_msgqueuepair.mnu) and delete the incorrect mnu files directly under Core.

This is correct; the two menus directly under Core should be deleted.

I can correct this. Are there any functional issues with the menus themselves that I should address at the same time, @shivaprasad-basavaraj ?

The mnu files themselves looked fine in this PR. One other thing we might have to do is update the VIPB files as well to use the new mnu files and install them to the correct location so that installs from LabVIEW and the VIPM files use the same mnu files. @niACS had updated the Core/Actor Framework 2024 for 2020.vipb file to do this in his PR #153 . We probably need to update Core/Actor Framework.vipb along with this.

@niACS
Copy link
Copy Markdown
Collaborator

niACS commented Mar 12, 2026

If all the files are where they should be, I'd expect you can just take the .vipb from my PR branch.

@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 12, 2026

@CaseyZS This PR still leaves two copies of the mnu files in the repo which is confusing. The original mnu files which are incorrect are directly under the Core folder and the new corrected ones in the new folder structure you created. I would rather move all the mnu files into the new folder strcuture (including _actorframework_msgqueuepair.mnu) and delete the incorrect mnu files directly under Core.

This is correct; the two menus directly under Core should be deleted.

I can correct this. Are there any functional issues with the menus themselves that I should address at the same time, @shivaprasad-basavaraj ?

The mnu files themselves looked fine in this PR. One other thing we might have to do is update the VIPB files as well to use the new mnu files and install them to the correct location so that installs from LabVIEW and the VIPM files use the same mnu files. @niACS had updated the Core/Actor Framework 2024 for 2020.vipb file to do this in his PR #153 . We probably need to update Core/Actor Framework.vipb along with this.

It's probably a good idea to do this, though I suggest putting it in its own issue and PR to keep things nicely separated.

@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 12, 2026

I've deleted the old menus directly under "Core" and I've moved "_actorframework_msgqueuepair.mnu" but I don't see where that actually gets used. There's nothing that I can see on the new palettes that would correspond to that menu. Am I missing something or can it be deleted?

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

I've deleted the old menus directly under "Core" and I've moved "_actorframework_msgqueuepair.mnu" but I don't see where that actually gets used. There's nothing that I can see on the new palettes that would correspond to that menu. Am I missing something or can it be deleted?

The msgqueuepair mnu is a subpalette of the Advanced palette of actor framework. This shouldn't be deleted.

image

@shivaprasad-basavaraj shivaprasad-basavaraj merged commit 81d79f4 into ni:develop Mar 13, 2026
1 check failed
@CaseyZS
Copy link
Copy Markdown
Collaborator Author

CaseyZS commented Mar 13, 2026

Ah, OK. I see the PR was accepted and merged, so we're good for now? I'll create an issue to capture including the new menus in the VIPB file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants