Skip to content

Created menus as source code, not as VIPM artifacts. Updated build s…#153

Open
niACS wants to merge 1 commit intoni:developfrom
niACS:hotfix/152-add-correct-palettes
Open

Created menus as source code, not as VIPM artifacts. Updated build s…#153
niACS wants to merge 1 commit intoni:developfrom
niACS:hotfix/152-add-correct-palettes

Conversation

@niACS
Copy link
Copy Markdown
Collaborator

@niACS niACS commented Feb 20, 2026

…pecification.

GitHub Issue for the Pull Request

Link to the relevant GitHub issue

GitHub Discussions Related to this Pull Request

None

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

  • [x ] I do not require assistance from NI to complete any of the following checks.
  • [x ] The changes in this PR are based on the appropriate NI-repo feature branch
  • I am submitting the changes in this PR to the appropriate NI-repo feature branch
  • I built a VI Package using the Powershell build tool.
  • I installed the VI Package produced by the Powershell build tool and tested my change.
  • I tested my changes after installing the VI package.
  • NI has my contributor license agreement.

I built and installed the VI package locally. I don't know the state or process for using the Powershell tool.

Summary of Changes

I added the appropriate menus to the correct menu folders, and disabled menu creation in the VIPM build specification. The following were modified or updated:
actorframework.mnu
_actorframework_experttools.mnu
_actorframework_msgqueuepair.mnu
_actor_framework_testsupport.mnu (new)
actorframework_controls.mnu (new)

Reason for Change

2026 Q1 shipped with the old palettes. These are the correct ones.

Visual Aids

Include any visual aids that would help the reviewer gain additional context.

Additional Information

Include any further details that may assist the reviewer in understanding the context of this PR.

Testing

This section describes the automated and manual tests performed for this bugfix/feature.

Manual Tests

Manual inspection. Yep, the new palettes are there.

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

The palette menus probably shouldn't have the 2024 subscript.

image

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

With the update to the mnu's the help tag, description have been lost.

image

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

If the intention of this change was that the new mnu files are only for AF 2024 for 2020 package to have these mnu files, then I would rather have subfolders under Menus where both these new mnu's and the existing mnu's go to.

@gregr-ni

@niACS
Copy link
Copy Markdown
Collaborator Author

niACS commented Feb 25, 2026

The palette menus probably shouldn't have the 2024 subscript.

I edited the palettes using the native LabVIEW palette editing tools, and removed that subscript. It does not appear when I run the LabVIEW IDE. How is it still there, and what tool do I need to use to make that change?

@niACS
Copy link
Copy Markdown
Collaborator Author

niACS commented Feb 25, 2026

With the update to the mnu's the help tag, description have been lost.

How do I edit that from the LabVIEW IDE?

@niACS
Copy link
Copy Markdown
Collaborator Author

niACS commented Feb 25, 2026

If the intention of this change was that the new mnu files are only for AF 2024 for 2020 package to have these mnu files, then I would rather have subfolders under Menus where both these new mnu's and the existing mnu's go to.

These mnu files are intended to replace and extend the mnu files that ship with 2026 Q1. These are the correct files for that release of Actor Framework.

@niACS
Copy link
Copy Markdown
Collaborator Author

niACS commented Feb 25, 2026

It looks like I hit some "gotchas" in palette editing regarding things that are not accessible through the normal "Advanced » Edit Palette Set..." menu option. Are there other editing tools with which I am not familiar, and can they be made available?

@gregr-ni
Copy link
Copy Markdown
Collaborator

If the intention of this change was that the new mnu files are only for AF 2024 for 2020 package to have these mnu files, then I would rather have subfolders under Menus where both these new mnu's and the existing mnu's go to.

@gregr-ni

The Menus directory represents LabVIEW's Menus directory. We should not create hierarchy in source that doesn't match what would ship. If you feel like you need more qualification on the purpose of that directory, you could make an additional level above Menus but you shouldn't mess with Menus and below.

@shivaprasad-basavaraj
Copy link
Copy Markdown
Collaborator

It looks like I hit some "gotchas" in palette editing regarding things that are not accessible through the normal "Advanced » Edit Palette Set..." menu option. Are there other editing tools with which I am not familiar, and can they be made available?

You can use the "Write Palette.vi" present in LabVIEW to edit the palette file. That gives you fine grained control of editing the palette file. You can use the mnu files that are currently directly under the Core folder as the source for the finer details of the new palette files. Also after the change we should probably just have version Core\Menus and delete the ones directly under Core to avoid confusion.

@CaseyZS
Copy link
Copy Markdown
Collaborator

CaseyZS commented Mar 4, 2026

Since @niACS is OOO for the next couple weeks, @dhooks1 and I will look into it on the SteerCo side of things.

@CaseyZS
Copy link
Copy Markdown
Collaborator

CaseyZS commented Mar 6, 2026

The .mnu files referenced in this PR still appear to have a "2024 for 2020" submenu (that's missing). I'm creating a new PR to address the issues listed by @shivaprasad-basavaraj. Link to follow.

@CaseyZS
Copy link
Copy Markdown
Collaborator

CaseyZS commented Mar 6, 2026

Here's what I saw from @niACS 's fork:
AF Palette - Allen's

In #154 I'm only replacing the deprecated files:
AF Palette - Main
becomes
AF Palette - Main (fixed)

AF Palette - Advanced becomes AF Palette - Advanced (fixed)

@niACS
Copy link
Copy Markdown
Collaborator Author

niACS commented Mar 7, 2026

The advanced palette should also have a Test Support subpalette, as shown here:
image

The subpalette has these items:
image

There is also a controls palette:
image

These should all have been in my PR. I am OOO next week, but working, so I can answer questions. I can also send a zip file of the correct palette set, if that would help.

@CaseyZS
Copy link
Copy Markdown
Collaborator

CaseyZS commented Mar 9, 2026

I can recreate those changes in the other PR since I don't have access to the branch in yours @niACS .

@CaseyZS
Copy link
Copy Markdown
Collaborator

CaseyZS commented Mar 9, 2026

@niACS 's comments have been incorporated into #154 (again, because I don't have access to Allen's branch directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants