Skip to content

Rmats prep PR#10128

Merged
SPPearce merged 28 commits intonf-core:masterfrom
akaviaLab:rmats
Apr 29, 2026
Merged

Rmats prep PR#10128
SPPearce merged 28 commits intonf-core:masterfrom
akaviaLab:rmats

Conversation

@akaviaLab
Copy link
Copy Markdown
Contributor

@akaviaLab akaviaLab commented Feb 23, 2026

PR checklist

This is a PR of rmats/prep.
RMATS processes BAM files from RNAseq and identifies splice junctions used, and differences between groups of samples.
RMATS is composed of 4 stages (that can be run together), but I'm planning to split into steps

  1. Prep which processes BAM files (this PR)
  2. Post, which process the output of prep
  3. Dividing the post files into groups, based on the statistics
  4. Stats - comparing two groups. Since stats can only compare two groups, I will set up stage 3 to read contrasts and set up the groups.

I will then set up a workflow that does all 4.

Eventually, the workflow will close #8699 . Please do not close the issue yet.

This creates the main.nf for rmats.py prep command, and adds tests for multiple parameters that can be given to rmats prep.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@mashehu mashehu marked this pull request as draft February 24, 2026 11:51
Comment thread modules/nf-core/rmats/prep/optional_parameters Outdated
@akaviaLab akaviaLab marked this pull request as ready for review March 8, 2026 17:20
@akaviaLab akaviaLab changed the title Rmats work in progress PR Rmats prep PR Mar 8, 2026
Comment thread modules/nf-core/rmats/prep/main.nf
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/tests/nextflow.config Outdated
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Copy link
Copy Markdown
Contributor Author

@akaviaLab akaviaLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me knwo what you think about these comments

Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/main.nf
Comment thread modules/nf-core/rmats/prep/tests/main.nf.test Outdated
Comment thread modules/nf-core/rmats/prep/tests/main.nf.test Outdated
Comment thread modules/nf-core/rmats/prep/tests/main.nf.test Outdated
Comment thread modules/nf-core/rmats/prep/tests/nextflow.config Outdated
akaviaLab and others added 3 commits March 31, 2026 09:44
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/main.nf Outdated
Comment thread modules/nf-core/rmats/prep/tests/nextflow.config Outdated
@SPPearce
Copy link
Copy Markdown
Contributor

@akaviaLab , do you need a re-review on this?

@akaviaLab
Copy link
Copy Markdown
Contributor Author

akaviaLab commented Apr 28, 2026 via email

@akaviaLab
Copy link
Copy Markdown
Contributor Author

@akaviaLab , do you need a re-review on this?

Yes please! I've fixed everything, but I need you to approve before merging.

@SPPearce SPPearce added this pull request to the merge queue Apr 29, 2026
@akaviaLab
Copy link
Copy Markdown
Contributor Author

Thank you!

Merged via the queue into nf-core:master with commit 93b0719 Apr 29, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: RMATS

3 participants