Rmats prep PR#10128
Merged
SPPearce merged 28 commits intonf-core:masterfrom Apr 29, 2026
Merged
Conversation
mashehu
reviewed
Feb 25, 2026
SPPearce
reviewed
Mar 9, 2026
SPPearce
reviewed
Mar 9, 2026
SPPearce
reviewed
Mar 9, 2026
…s and starting a list of optional parameters
akaviaLab
commented
Mar 18, 2026
Contributor
Author
akaviaLab
left a comment
There was a problem hiding this comment.
Let me knwo what you think about these comments
SPPearce
reviewed
Mar 20, 2026
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
SPPearce
reviewed
Apr 14, 2026
Contributor
|
@akaviaLab , do you need a re-review on this? |
Contributor
Author
|
I need an approval from a core maintainer to merge. I'll fix the URL, but
apart from tgat, can you approve?
Ive changed everything as discussed.
…On Tue, 28 Apr 2026, 11:37 am Simon Pearce, ***@***.***> wrote:
*SPPearce* left a comment (nf-core/modules#10128)
<#10128 (comment)>
@akaviaLab <https://github.com/akaviaLab> , do you need a re-review on
this?
—
Reply to this email directly, view it on GitHub
<#10128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQYYZVBQNPRHI4ATVZQPJD4YCCW5AVCNFSM6AAAAACV4PSVDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMZUGQ2DOMRWGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
Yes please! I've fixed everything, but I need you to approve before merging. |
SPPearce
approved these changes
Apr 29, 2026
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This is a PR of rmats/prep.
RMATS processes BAM files from RNAseq and identifies splice junctions used, and differences between groups of samples.
RMATS is composed of 4 stages (that can be run together), but I'm planning to split into steps
I will then set up a workflow that does all 4.
Eventually, the workflow will close #8699 . Please do not close the issue yet.
This creates the main.nf for rmats.py prep command, and adds tests for multiple parameters that can be given to rmats prep.
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda