Improve startup time by avoiding redundant downloads

[AhmmedSamier]

Problem

Currently, the extension attempts to install/download the Angular Language Server and TypeScript packages every time the language server starts. This causes a significant delay on every startup, even if the packages are already installed and up-to-date.

Solution

This PR updates the startup logic to:

Check the package.json of the installed @angular/language-server and typescript packages in node_modules.
Compare the installed version with the requested version (or the latest version if configured as "latest").
Skip the download/install step if the versions match and the server file exists.
This drastically reduces startup time for subsequent runs while still ensuring the extension updates when the configured version changes.

[jpike88]

This smells a little bit like an AI Agent PR. not a bad thing, just want to confirm how you did it, and how it's been tested?

[AhmmedSamier]

This smells a little bit like an AI Agent PR. not a bad thing, just want to confirm how you did it, and how it's been tested?

I’m not primarily a Rust developer, but I use Zed for Angular development. I used Google Jules to implement the required changes and relied on its built-in review during the verification step. In addition, I manually tested the functionality to ensure everything works as expected

[nathansbradshaw]

Thanks for the PR and response @AhmmedSamier . I appreciate the work you and the community don't keep this plugin alive.

I think to get this PR through getting a second set of verification that everything works would be nice. I don't work with angular anymore, so I'll defer the second set of eyes to someone with more recent experience

[AhmmedSamier]

Hi @nathansbradshaw 👋

I wanted to check in on the status of this PR.

Could you share if there’s anything else needed to move it forward (e.g., additional verification/testing, adjustments to the changes, or a second reviewer)? I’d be happy to help with whatever is needed to get this merged. Thanks!

[nathansbradshaw]

@AhmmedSamier Some verification would be great and I'll review it later today to see if we can get it merged

[nathansbradshaw]

I'm sorry, I haven't had any time to look into this. @jpike88 do you have any availability to verify this and merge it in?

[jpike88]

@AhmmedSamier what happens if I have folder X opened which is a monorepo, and the package.json of interest is in subfolder Y (like a client/ directory)?

Seems like that check is very brittle.

I think at least:

• being able to manually override the path it looks at
• or better, have it start in the directory of an open file, and work your way upwards to the first instance of a package.json that references an angular package, and then just work with that for the remainder of the session

[jpike88]

closing PR because submitter is not taking proper ownership of this pr. there are also copilot requests left unaddressed. submitter says he tested it himself, but that's not enough assurance to confidently move forward

[AhmmedSamier]

@jpike88 sorry what do you mean by unaddressed copilot requests, and it been 4 months since this pull request opened and waiting for review
What can I do to get it merged

[jpike88]

woops i copy pasted that from another repo and hadn't had a coffee yet!

important to address #72 (comment), otherwise it's may break on monorepos.