feat: add angular-language-server extension v1.0.0#6000
Open
pBouillon wants to merge 1 commit intozed-industries:mainfrom
Open
feat: add angular-language-server extension v1.0.0#6000pBouillon wants to merge 1 commit intozed-industries:mainfrom
pBouillon wants to merge 1 commit intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @pBouillon on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @pBouillon on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I work with Angular almost daily and originally developed this to support my own development needs. This project was initially inspired by nathansbradshaw/zed-angular, but the implementation drifted significantly as I learned my way through the Zed API, Rust, and Tree-sitter. Contributing the changes back would have meant opening a pull request replacing most of the existing codebase, which did not feel like the right thing to do as an external contributor.
Once I had a working version, I noticed the original author mentioned they no longer work with Angular actively. This encouraged me to refine this into a formal extension for others to use.
This extension offers:
@if,@for)Compared to the existing extension, this version introduces a few functional differences:
node_modulein the project rootI am aware the contribution guidelines generally discourage duplicate extensions. I hope the differences outlined above make a reasonable case for this one to be listed alongside the existing extension rather than as a replacement for it.
If this is not something the Zed team wishes to include as a separate extension at this time, I completely understand. Regardless of the outcome, thank you for your time and for the work you put into reviewing these contributions.
Preview
Completion in templates
Diagnostics
Hover information
Go to definition
Outline
Syntax highlighting