Skip to content

fix: nil FlowControl after ApplyTo to unblock readyz #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotwells merged 1 commit into from
May 23, 2026
Merged

fix: nil FlowControl after ApplyTo to unblock readyz #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cmd/ipam/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,16 @@ func (o *IPAMServerOptions) Config() (*ipamapiserver.Config, error) {
// healthchecks.
o.RecommendedOptions.Etcd = nil

// Delegating aggregated apiservers defer API Priority and Fairness to the
// main kube-apiserver. Disabling APF here avoids the FlowSchema and
// PriorityLevelConfiguration informers that would otherwise block readyz.
genericConfig.FlowControl = nil

if err := o.RecommendedOptions.ApplyTo(genericConfig); err != nil {
return nil, fmt.Errorf("apply recommended options: %w", err)
}

// Delegating aggregated apiservers defer API Priority and Fairness to the
// main kube-apiserver. ApplyTo may re-initialize FlowControl, so nil it
// out here (after ApplyTo) to prevent the FlowSchema and
// PriorityLevelConfiguration informers from blocking readyz.
genericConfig.FlowControl = nil

codec := ipamapiserver.Codecs.LegacyCodec(ipamapiserver.Scheme.PrioritizedVersionsAllGroups()...)

pgGetter, err := pgstore.NewRESTOptionsGetter(o.PostgresDSN)
Expand Down
Loading