fix: nil FlowControl after ApplyTo to unblock readyz#29
Merged
Conversation
RecommendedOptions.ApplyTo re-initializes genericConfig.FlowControl, so setting it to nil before the call had no effect. The APF controller started anyway, and its FlowSchema/PriorityLevelConfiguration informers never synced — blocking readyz indefinitely. Move the nil assignment to after ApplyTo so it takes effect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
scotwells
requested review from
JoseSzycho,
ecv,
kevwilliams,
privateip and
savme
ecv
approved these changes
May 23, 2026
ecv
left a comment
ecv
left a comment
There was a problem hiding this comment.
too many comments, i'll educate claude as to terseness
legit thinking we should enable caveman mode companywide to avoid tokenmaxxing
Contributor
Author
|
Idk, that's a pretty helpful comment. Not obvious at all what that setting does without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The IPAM apiserver pods in staging are stuck
0/1 Ready. The readiness probe returns HTTP 500 indefinitely with:The APF (API Priority and Fairness) controller was starting and waiting to sync
FlowSchemaandPriorityLevelConfigurationobjects from the main kube-apiserver — resources the IPAM aggregated apiserver has no reason to watch.Root Cause
A previous fix (
885bd93) setgenericConfig.FlowControl = nilbefore callingRecommendedOptions.ApplyTo(genericConfig). ButApplyTore-initializesFlowControlinternally, so the nil had no effect and the APF controller started anyway.Fix
Move
genericConfig.FlowControl = nilto afterApplyTo. One line change.Impact
🤖 Generated with Claude Code