-
Notifications
You must be signed in to change notification settings - Fork 60
feat(react-cap-theme): add react-combobox components
#648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GianoglioEnrico
merged 4 commits into
microsoft:main
from
GianoglioEnrico:egianoglio/sync-combobox
May 11, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-contrib-react-cap-theme-d963b118-5dff-48e8-9c7a-a99724185c4e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "add react-combobox components", | ||
| "packageName": "@fluentui-contrib/react-cap-theme", | ||
| "email": "egianoglio@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
packages/react-cap-theme/src/components/react-combobox/components/Combobox/Combobox.types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import type { | ||
| ComboboxProps as BaseProps, | ||
| ComboboxSlots as BaseSlots, | ||
| ComboboxState as BaseState, | ||
| } from '@fluentui/react-combobox'; | ||
| import type { | ||
| ComponentProps, | ||
| ComponentState, | ||
| Slot, | ||
| } from '@fluentui/react-utilities'; | ||
|
|
||
| /** | ||
| * Slot configuration for the Combobox component. | ||
| * Adds the SP-specific contentBefore slot. The listbox slot is inherited | ||
| * from Fluent and restyled in `useComboboxStyles`. | ||
| * @alpha | ||
| */ | ||
| export type ComboboxSlots = BaseSlots & { | ||
| /** | ||
| * Element before the input text, e.g. an icon or avatar. | ||
| */ | ||
| contentBefore?: Slot<'span'>; | ||
| }; | ||
|
|
||
| /** | ||
| * Properties for configuring the Combobox component. | ||
| * @alpha | ||
| */ | ||
| export type ComboboxProps = ComponentProps< | ||
| Pick<ComboboxSlots, 'contentBefore'> | ||
| > & | ||
| Omit<BaseProps, 'color'> & { | ||
| /** | ||
| * The color variant. | ||
| * | ||
| * - 'brand' (default): Primary emphasis using brand colors. | ||
| * - 'neutral': Secondary emphasis using neutral colors. | ||
| * | ||
| * @default 'brand' | ||
| */ | ||
| // FIXME: Must not graduate to beta. Style implementation references Fluent tokens directly. | ||
| // `color` and `NeutralThemeProvider` solve the same brand/neutral switching problem at different | ||
| // levels of the stack with no defined interaction. Graduating locks in an API contract that may | ||
| // need to change once a proper token-based theming approach is defined. | ||
| color?: 'neutral' | 'brand'; | ||
| }; | ||
|
|
||
| /** | ||
| * State used in rendering the Combobox component. | ||
| * @alpha | ||
| */ | ||
| export type ComboboxState = ComponentState<ComboboxSlots> & | ||
| Omit<BaseState, 'components'> & | ||
| Required<Pick<ComboboxProps, 'color'>>; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.