fix: VM size updates, private endpoint refactoring, documentation updates#464
Open
Prekshith-Microsoft wants to merge 2 commits intopsl-cps-v2from
Open
fix: VM size updates, private endpoint refactoring, documentation updates#464Prekshith-Microsoft wants to merge 2 commits intopsl-cps-v2from
Prekshith-Microsoft wants to merge 2 commits intopsl-cps-v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
This pull request updates the default jumpbox VM size to a more modern and widely available SKU (
Standard_D2s_v5), improves documentation and troubleshooting guidance for VM sizing and networking, and refactors private endpoint creation for AI services to use explicit modules for clarity and maintainability.Jumpbox VM Size Default and Documentation Updates:
Standard_DS2_v2toStandard_D2s_v5ininfra/main.bicep, with corresponding documentation updates to recommend newer SKUs and clarify which VM sizes support accelerated networking. [1] [2] [3]infra/main.waf.parameters.jsonand added support for overriding the VM size using theAZURE_ENV_VM_SIZEenvironment variable.Troubleshooting and Error Guidance Improvements:
AI Services Private Networking Refactor:
infra/main.bicepto use explicitprivate-endpointmodules, improving clarity and aligning with best practices for private networking. [1] [2] [3] [4]Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information