Skip to content

Fix only-pnpm to support pnpm 11, and dedupe script #27332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CraigMacomber wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −31
Open

Fix only-pnpm to support pnpm 11, and dedupe script #27332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c37b05
Fix only-pnpm to support pnpm 11, and dedupe script
CraigMacomber May 18, 2026
c3257ff
Potential fix for pull request finding
CraigMacomber May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/test/test-version-utils/compat-workspaces/full/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
"license": "MIT",
"author": "Microsoft and contributors",
"scripts": {
"preinstall": "node ../scripts/only-pnpm.cjs"
"preinstall": "node ../../../../../scripts/only-pnpm.cjs"
Copy link
Copy Markdown
Contributor Author

@CraigMacomber CraigMacomber May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is private, so I don't think it gets installed, but maybe I'm missing something about how its used.

}
}
29 changes: 0 additions & 29 deletions packages/test/test-version-utils/compat-workspaces/scripts/only-pnpm.cjs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/only-pnpm.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const message = `
╚══════════════════════════════════════════════════════════════════╝
`;

const used_pnpm = process.env.npm_config_user_agent.startsWith(`pnpm`);
const used_pnpm = (process.env.npm_execpath ?? "").includes(`pnpm`);
Copy link
Copy Markdown
Contributor Author

@CraigMacomber CraigMacomber May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone know why we have duplicate copies of this script? I think having them all point at the same one would be fine (other than CI being broken for some of server at the moment which would block this PR if I did that here).


if (!used_pnpm) {
console.error(message);
Expand Down
Loading