#303: Fix PluginCheck to support project-scoped plugins#305
Merged
Conversation
- Add two-tier lookup (project settings.local.json → global settings.json) matching MCPServerCheck pattern - Extract Constants.FileNames.settingsLocal to replace 5 string literals across 4 files - Add 7 unit tests, 2 derived-check tests, and 1 integration test (910 total)
- Change projectSettingsCorrupt Bool to projectSettingsError String? to include error details - Return .warn when plugin enabled globally but project settings.local.json is corrupt - Add tests for explicit false values, corrupt-with-no-global, and corrupt-with-absent-plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginCheckonly read~/.claude/settings.json, causing false negatives when plugins were enabled in project-scopedsettings.local.json. This adds two-tier scope lookup matching the existingMCPServerCheckpattern.Closes #303
Changes
projectRoot: URL?toPluginCheckwith two-tier lookup: projectsettings.local.jsonfirst, globalsettings.jsonfallbackprojectRootfromderiveDoctorCheck()toPluginCheck(was already available but not passed)Constants.FileNames.settingsLocalto replace string literals acrossCoreDoctorChecks,DoctorRunner,SyncScope,ConfigurationDiscovery, andProjectSyncStrategyTest plan
swift testpasses locally (910/910)swiftformat --lint .andswiftlintpass without violationsmcs sync,mcs doctor)Checklist for engine changes
DoctorRunnerIntegrationTests)