#238: Replace stringly-typed MCP scope and settings file refs#307
Merged
#238: Replace stringly-typed MCP scope and settings file refs#307
Conversation
- Use Constants.MCPScope.user/.local instead of bare "user"/"local" strings in ConfigurationDiscovery - Use scope.settingsPath.lastPathComponent instead of hardcoded "settings.local.json" in ProjectSyncStrategy display messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #238. PR #234 introduced
Constants.MCPScope.userand PR #305 extractedConstants.FileNames.settingsLocal, but a few call sites were missed. This finishes that cleanup — pure mechanical replacement, no behavioral change.Changes
"user"/"local"scope strings withConstants.MCPScope.user/.local"settings.local.json"display strings withscope.settingsPath.lastPathComponent, matching the pattern already used byConfiguratorTesting
swift build— compiles cleanlyswift test— all 913 tests passswiftformat+swiftlint— zero violationsComponent.swiftremains (intentionally kept as human-readable documentation)