Skip to content

fix: decode URL-escaped local filesystem paths in _init_filesystem#1057

Open
Sharon-codes wants to merge 1 commit intomalariagen:masterfrom
Sharon-codes:issue-find-and-fix
Open

fix: decode URL-escaped local filesystem paths in _init_filesystem#1057
Sharon-codes wants to merge 1 commit intomalariagen:masterfrom
Sharon-codes:issue-find-and-fix

Conversation

@Sharon-codes
Copy link
Copy Markdown
Contributor

Summary

  • decode URL-escaped local paths returned from url_to_fs() when protocol is local (file/local)
  • add a regression test that uses a file:// URI containing spaces and apostrophes

Closes #1056.

Validation

  • poetry run pytest -q tests/test_util.py tests/anoph/test_aim_data.py::test_aim_variants[gambcolu_vs_arab]

@Sharon-codes
Copy link
Copy Markdown
Contributor Author

Heyyy @jonbrenas Please check , found an issue , have solved it , if it is fine , please accept and close the PR!!! Thankssss

@Sharon-codes
Copy link
Copy Markdown
Contributor Author

Heyy @jonbrenas please check and close the PR , thankksss !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local file:// URLs with URL-escaped paths fail to open on LocalFileSystem

1 participant