fix(veff): handle single-child transcripts consistently#1026
Open
Sharon-codes wants to merge 2 commits intomalariagen:masterfrom
Open
fix(veff): handle single-child transcripts consistently#1026Sharon-codes wants to merge 2 commits intomalariagen:masterfrom
Sharon-codes wants to merge 2 commits intomalariagen:masterfrom
Conversation
Contributor
Author
|
@jonbrenas Heyy please check if its upto your liking or else let me know for any more changes , thanksss!!! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 90.08% 90.12% +0.03%
==========================================
Files 50 50
Lines 5428 5429 +1
==========================================
+ Hits 4890 4893 +3
+ Misses 538 536 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
heyy @jonbrenas please look into this and if as per liking , accept it !!! |
Contributor
Author
|
Heyy @jonbrenas if all good , please accept the PR , do let me know if you want me to add any changes , Thanksss !! |
Contributor
Author
|
@jonbrenas heyyy please check and close if all good !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
veff.Annotator.get_children() now always returns a DataFrame (fixes single-child transcript crash).
Added informative ValueError when transcript has no CDS features.
Added regression tests in tests/test_veff.py.
Validation:
poetry run pytest -q tests/test_veff.py passed.
poetry run pre-commit run --files malariagen_data/veff.py tests/test_veff.py passed.