Make vertex buffers optional in the TraditionalRaster pipeline and add VerticesFromVertexID.test#1155
Open
manon-traverse wants to merge 4 commits into
Open
Make vertex buffers optional in the TraditionalRaster pipeline and add VerticesFromVertexID.test#1155manon-traverse wants to merge 4 commits into
TraditionalRaster pipeline and add VerticesFromVertexID.test#1155manon-traverse wants to merge 4 commits into
Conversation
This was referenced May 5, 2026
manon-traverse
force-pushed
the
optional-vertex-buffer
branch
from
d9e8868 to
613332c
Compare
manon-traverse
force-pushed
the
optional-vertex-buffer
branch
from
46d19d0 to
19d13a2
Compare
manon-traverse
force-pushed
the
optional-vertex-buffer
branch
from
2447726 to
b7fe2f7
Compare
Contributor
Author
|
NOTE: CI is currently only failing because of the missing golden image in the offload-golden-images repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1154
Add a TraditionalRaster test that doesn't use a vertex buffer, but generates a triangle using the SV_VertexID. This is a pretty common use case in game engines.
To make this work this changes makes the specifying a vertex buffer optional.
Golden image is introduced in: llvm/offload-golden-images#7