Skip to content

CI: Output test coverprofile to Artifacts tab in Prow #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitorfloriano wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

CI: Output test coverprofile to Artifacts tab in Prow #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ TEST_DIR := test
TOOLS_DIR := hack/tools
TOOLS_BIN_DIR := $(abspath $(TOOLS_DIR)/$(BIN_DIR))
GO_INSTALL := ./scripts/go_install.sh
ARTIFACTS ?= .
Copy link
Copy Markdown
Contributor

@AvineshTripathi AvineshTripathi May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put it under either hack/tools/artifacts or something similar

Copy link
Copy Markdown
Contributor Author

@vitorfloriano vitorfloriano May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ./artifacts/ only?

Copy link
Copy Markdown
Member

@Priyankasaggu11929 Priyankasaggu11929 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatever we choose, let's make sure it is self-explanatory and added to .gitignore.

Within Kubernetes projects, I have seen a pattern of _output/* dir for collecting test artifacts, logs or binaries etc.


export PATH := $(abspath $(TOOLS_BIN_DIR)):$(PATH)

Expand Down Expand Up @@ -388,7 +389,7 @@ undeploy-full: undeploy ## Undeploy with all features.

.PHONY: test
test: manifests generate fmt vet setup-envtest ## Run tests.
KUBEBUILDER_ASSETS="$(KUBEBUILDER_ASSETS)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out
KUBEBUILDER_ASSETS="$(KUBEBUILDER_ASSETS)" go test $$(go list ./... | grep -v /e2e) -coverprofile $(ARTIFACTS)/cover.out

# TODO(user): To use a different vendor for e2e tests, modify the setup under 'tests/e2e'.
# The default setup assumes Kind is pre-installed and builds/loads the Manager Docker image locally.
Expand Down
Loading