CI: Output test coverprofile to Artifacts tab in Prow#257
Open
vitorfloriano wants to merge 1 commit into
Open
Conversation
When run in CI, the coverprofile output from the test will be sent to the artifacts tab in Prow. When run locally, make test will output the file to the root of the repo.
✅ Deploy Preview for node-readiness-controller canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
| TOOLS_DIR := hack/tools | ||
| TOOLS_BIN_DIR := $(abspath $(TOOLS_DIR)/$(BIN_DIR)) | ||
| GO_INSTALL := ./scripts/go_install.sh | ||
| ARTIFACTS ?= . |
Contributor
There was a problem hiding this comment.
i would put it under either hack/tools/artifacts or something similar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run in Prow,
make testwill output thecoverprofilefile to$ARTIFACTS, which is a directory already present and exported by Prow when usingdecorate: truein the job description, and will show up in the Artifacts tab in spyglass.When run locally,
make testwill output the file to the root of the repo, as it is currently.See: https://docs.prow.k8s.io/docs/components/pod-utilities/#what-the-test-container-can-expect
Follow-up to kubernetes/test-infra#37035