Skip to content

fix: add rule label to node_readiness_evaluation_duration_seconds metric #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shreya2005-2005 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix: add rule label to node_readiness_evaluation_duration_seconds metric #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/nodereadinessrule_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func (r *RuleReadinessController) processAllNodesForRule(ctx context.Context, ru

// evaluateRuleForNode evaluates a single rule against a single node.
func (r *RuleReadinessController) evaluateRuleForNode(ctx context.Context, rule *readinessv1alpha1.NodeReadinessRule, node *corev1.Node) error {
timer := prometheus.NewTimer(metrics.EvaluationDuration)
timer := prometheus.NewTimer(metrics.EvaluationDuration.WithLabelValues(rule.Name))
defer timer.ObserveDuration()
log := ctrl.LoggerFrom(ctx)

Expand Down
5 changes: 3 additions & 2 deletions internal/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,13 @@ var (
)

// EvaluationDuration tracks the duration of rule evaluations.
EvaluationDuration = prometheus.NewHistogram(
EvaluationDuration = prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Name: "node_readiness_evaluation_duration_seconds",
Help: "Duration of rule evaluations",
Help: "Duration of rule evaluations per rule",
Buckets: prometheus.DefBuckets,
},
[]string{"rule"},
)

// Failures tracks the number of operational failures.
Expand Down