Skip to content

fix: add rule label to node_readiness_evaluation_duration_seconds metric#244

Open
Shreya2005-2005 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Shreya2005-2005:fix/evaluation-duration-rule-label
Open

fix: add rule label to node_readiness_evaluation_duration_seconds metric#244
Shreya2005-2005 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Shreya2005-2005:fix/evaluation-duration-rule-label

Conversation

@Shreya2005-2005
Copy link
Copy Markdown
Contributor

@Shreya2005-2005 Shreya2005-2005 commented May 13, 2026

Description

node_readiness_evaluation_duration_seconds was defined as a plain
Histogram with no labels. All other per-rule metrics include a rule
label. Without it, operators cannot identify which rule is slow in
multi-rule clusters.

Related Issue

Fixes #243

Type of Change

/kind bug

Testing

  • go build ./... passes
  • make lint passes (0 issues)
  • go test ./internal/webhook/... passes (25/25)

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

NONE

…ric.

Signed-off-by: Shreya2005-2005 <bhakatmistu2005@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit a063a76
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a0414cfe0ba1a0007026b3b

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreya2005-2005
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Shreya2005-2005. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add rule label to node_readiness_evaluation_duration_seconds metric

2 participants