fix: add rule label to node_readiness_evaluation_duration_seconds metric#244
Conversation
…ric. Signed-off-by: Shreya2005-2005 <bhakatmistu2005@gmail.com>
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shreya2005-2005 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Shreya2005-2005. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
node_readiness_evaluation_duration_seconds was defined as a plain
Histogram with no labels. All other per-rule metrics include a rule
label. Without it, operators cannot identify which rule is slow in
multi-rule clusters.
Related Issue
Fixes #243
Type of Change
/kind bug
Testing
Checklist
Does this PR introduce a user-facing change?