Skip to content

Fix order-dependent assertions in TestTaxRatesClient integration test #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsalefter merged 3 commits into from
May 21, 2026
Merged

Fix order-dependent assertions in TestTaxRatesClient integration test #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
239c734
Fix order-dependent assertions in TestTaxRatesClient
Copilot May 20, 2026
4336e60
Add killbill-utils as compile dependency to fix OSGi ClassNotFoundExc…
Copilot May 20, 2026
c105350
Change killbill-utils dependency scope to runtime to fix Maven verify
Copilot May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@
<artifactId>killbill-metrics-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.kill-bill.commons</groupId>
<artifactId>killbill-utils</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.kill-bill.testing</groupId>
<artifactId>testing-mysql-server</artifactId>
Expand Down
35 changes: 23 additions & 12 deletions src/test/java/org/killbill/billing/plugin/avatax/client/TestTaxRatesClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@

package org.killbill.billing.plugin.avatax.client;

import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;

import org.killbill.billing.plugin.avatax.AvaTaxRemoteTestBase;
import org.killbill.billing.plugin.avatax.client.model.RateModel;
import org.killbill.billing.plugin.avatax.client.model.TaxRateResult;
import org.testng.Assert;
import org.testng.annotations.Test;
Expand All @@ -41,20 +46,26 @@ private void checkSFRates(final TaxRateResult result) {
Assert.assertEquals(result.totalRate, 0.08625);
Assert.assertEquals(result.rates.size(), 4);

Assert.assertEquals(result.rates.get(0).rate, 0.0025);
Assert.assertEquals(result.rates.get(0).name, "CA COUNTY TAX");
Assert.assertEquals(result.rates.get(0).type, "County");
// Sort rates by type then by rate to avoid order-dependent assertions,
// as the AvaTax API does not guarantee a specific ordering.
final List<RateModel> sorted = new ArrayList<>(result.rates);
sorted.sort(Comparator.comparing((RateModel r) -> r.type)
.thenComparingDouble(r -> r.rate));

Assert.assertEquals(sorted.get(0).rate, 0.0025);
Assert.assertEquals(sorted.get(0).name, "CA COUNTY TAX");
Assert.assertEquals(sorted.get(0).type, "County");

Assert.assertEquals(result.rates.get(1).rate, 0.06);
Assert.assertEquals(result.rates.get(1).name, "CA STATE TAX");
Assert.assertEquals(result.rates.get(1).type, "State");
Assert.assertEquals(sorted.get(1).rate, 0.01);
Assert.assertEquals(sorted.get(1).name, "CA SPECIAL TAX");
Assert.assertEquals(sorted.get(1).type, "Special");

Assert.assertEquals(result.rates.get(2).rate, 0.01375);
Assert.assertEquals(result.rates.get(2).name, "CA SPECIAL TAX");
Assert.assertEquals(result.rates.get(2).type, "Special");
Assert.assertEquals(sorted.get(2).rate, 0.01375);
Assert.assertEquals(sorted.get(2).name, "CA SPECIAL TAX");
Assert.assertEquals(sorted.get(2).type, "Special");

Assert.assertEquals(result.rates.get(3).rate, 0.01);
Assert.assertEquals(result.rates.get(3).name, "CA SPECIAL TAX");
Assert.assertEquals(result.rates.get(3).type, "Special");
Assert.assertEquals(sorted.get(3).rate, 0.06);
Assert.assertEquals(sorted.get(3).name, "CA STATE TAX");
Assert.assertEquals(sorted.get(3).type, "State");
}
}
Loading