Fix order-dependent assertions in TestTaxRatesClient integration test#38
Merged
Merged
Conversation
The AvaTax API does not guarantee a specific ordering of tax rates in the response. Sort rates by type and rate before asserting to make the integration test resilient to ordering changes. Agent-Logs-Url: https://github.com/killbill/killbill-avatax-plugin/sessions/7990deea-7aa0-49b7-b2a6-fe07995c269a Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
xsalefter
May 20, 2026 20:55
View session
…eption for MultiValueMap The PluginTaxCalculator parent class uses MultiValueMap from killbill-utils, which is declared as provided scope in killbill-base-plugin. Since the OSGi system bundle does not export org.killbill.commons.utils.collect, the plugin bundle must embed killbill-utils to resolve the class at runtime. Agent-Logs-Url: https://github.com/killbill/killbill-avatax-plugin/sessions/7b07bbaf-6f35-4eec-8515-a697760195c4 Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
The compile scope was causing verification failures. The runtime scope still ensures the classes get embedded in the OSGi bundle (via Embed-Dependency *;scope=compile|runtime;inline=true) while avoiding compile-time conflicts. Agent-Logs-Url: https://github.com/killbill/killbill-avatax-plugin/sessions/afd521cd-c93b-4bcf-a955-362f71546711 Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.killbill.commons.utils.collect.MultiValueMapnot found at OSGi runtime becausekillbill-utilsisprovidedscope inkillbill-base-pluginand not exported by the OSGi system bundlekillbill-utilsdependency in avatax-plugin pom.xml so it gets embedded in the bundleruntimeto fix Maven verify failures while still embedding in the OSGi bundle