Skip to content

Fiddle: update to latest ui-react + use focus-visible instead of focusFixer pattern #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishan711 merged 2 commits into from
Dec 4, 2025
Merged

Fiddle: update to latest ui-react + use focus-visible instead of focusFixer pattern #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844053a
.
krishan711 Dec 4, 2025
daa7d21
.
krishan711 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';

import type { Preview } from '@storybook/react-vite';

import '@kibalabs/ui-react/dist/index.css';
import '@kibalabs/ui-react/styles.css';
import '../src/styles.scss';
import { ToastContainer } from '../src';

Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"devDependencies": {
"@kibalabs/build": "0.13.3-next.13",
"@kibalabs/ui-react": "0.11.3-next.18",
"@kibalabs/ui-react": "^0.11.3-next.22",
"@storybook/addon-docs": "10.1.2",
"@storybook/react-vite": "10.1.2",
"@types/react": "19.2.7",
Expand Down
14 changes: 4 additions & 10 deletions src/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@ export function Toast({

const toastClassName = getClassName(Toast.displayName, className, isClickable && 'clickable', ...(variant?.split('-') || []));

const innerContent = (
<span className='KibaToastFocusFixer' tabIndex={-1}>
{props.children}
</span>
);

if (props.target) {
if (isUsingCoreRouting && targetShouldOpenSameTab && isTargetWithinApp) {
return (
Expand All @@ -51,7 +45,7 @@ export function Toast({
onClick={onClicked}
tabIndex={props.tabIndex || 0}
>
{innerContent}
{props.children}
</CoreLink>
);
}
Expand All @@ -65,7 +59,7 @@ export function Toast({
onClick={onClicked}
tabIndex={props.tabIndex || 0}
>
{innerContent}
{props.children}
</a>
);
}
Expand All @@ -79,7 +73,7 @@ export function Toast({
tabIndex={props.tabIndex || 0}
type='button'
>
{innerContent}
{props.children}
</button>
);
}
Expand All @@ -90,7 +84,7 @@ export function Toast({
className={toastClassName}
tabIndex={props.tabIndex || 0}
>
{innerContent}
{props.children}
</div>
);
}
Expand Down
49 changes: 21 additions & 28 deletions src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
border: none;
text-decoration: none;
cursor: default;
background-clip: border-box;
position: relative;
box-sizing: border-box;
&.clickable {
cursor: pointer;
}
Expand All @@ -49,57 +52,47 @@
}
}

.KibaToastFocusFixer {
outline: none;
background-clip: border-box;
width: 100%;
height: 100%;
position: relative;
display: flex;
box-sizing: border-box;
}

}

@layer kiba-theme {
.KibaToast {
> .KibaToastFocusFixer {
// Use same styling as card from ui-react
background-color: var(--kiba-color-background-light10, #ffffff);
border-color: var(--kiba-color-background-dark05, rgba(0, 0, 0, 0.05));
border-width: var(--kiba-border-width, 1px);
border-style: solid;
border-radius: var(--kiba-border-radius, 0.5em);
box-shadow: 0px 8px 8px -6px rgba(0, 0, 0, 0.15);
padding: var(--kiba-padding, 0.5em) var(--kiba-padding-wide, 1em);
color: var(--kiba-color-text, #333333);
transition-duration: 0.3s;
}
&:hover > .KibaToastFocusFixer {
// Use same styling as card from ui-react
background-color: var(--kiba-color-background-light10, #ffffff);
border-color: var(--kiba-color-background-dark05, rgba(0, 0, 0, 0.05));
border-width: var(--kiba-border-width, 1px);
border-style: solid;
border-radius: var(--kiba-border-radius, 0.5em);
box-shadow: 0px 8px 8px -6px rgba(0, 0, 0, 0.15);
padding: var(--kiba-padding, 0.5em) var(--kiba-padding-wide, 1em);
color: var(--kiba-color-text, #333333);
transition-duration: 0.3s;
&:hover {
background-color: var(--kiba-color-background, #ffffff);
}
&:active > .KibaToastFocusFixer {
&:active {
background-color: var(--kiba-color-background-dark10, #f0f0f0);
}
&:focus > .KibaToastFocusFixer {
&:focus-visible {
border-color: var(--kiba-color-background-dark50, rgba(0, 0, 0, 0.5));
}
// Variant styles
&.success > .KibaToastFocusFixer {
&.success {
background-color: var(--kiba-color-success-clear90, #d4edda);
color: var(--kiba-color-success-dark25, #155724);
border-color: var(--kiba-color-success-clear75, #c3e6cb);
}
&.error > .KibaToastFocusFixer {
&.error {
background-color: var(--kiba-color-error-clear90, #f8d7da);
color: var(--kiba-color-error-dark25, #721c24);
border-color: var(--kiba-color-error-clear75, #f5c6cb);
}
&.warning > .KibaToastFocusFixer {
&.warning {
background-color: var(--kiba-color-warning-clear90, #fff3cd);
color: var(--kiba-color-warning-dark25, #856404);
border-color: var(--kiba-color-warning-clear75, #ffeeba);
}
&.info > .KibaToastFocusFixer {
&.info {
background-color: var(--kiba-color-info-clear90, #d1ecf1);
color: var(--kiba-color-info-dark25, #0c5460);
border-color: var(--kiba-color-info-clear75, #bee5eb);
Expand Down
Loading