Fiddle: update to latest ui-react + use focus-visible instead of focusFixer pattern#12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Toast component by removing the legacy focusFixer wrapper pattern and updating to the latest @kibalabs/ui-react version. The changes simplify the component structure by applying styles directly to the toast element and using the modern :focus-visible pseudo-class for better keyboard navigation UX.
Key Changes:
- Updated
@kibalabs/ui-reactdependency from0.11.3-next.18to^0.11.3-next.22 - Removed the
KibaToastFocusFixerwrapper span element from the component structure - Refactored CSS to apply styles directly to
.KibaToastinstead of nested selectors, and replaced:focuswith:focus-visible
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated @kibalabs/ui-react devDependency to version ^0.11.3-next.22 with caret for flexible version range |
| package-lock.json | Updated lockfile to reflect the new @kibalabs/ui-react version and integrity hash |
| src/component.tsx | Removed KibaToastFocusFixer wrapper span and simplified component to render children directly |
| src/styles.scss | Removed .KibaToastFocusFixer class, moved its properties to .KibaToast, flattened nested selectors, and replaced :focus with :focus-visible |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: