Skip to content

Fiddle: change export to be all in styles.css and styles.scss #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishan711 merged 1 commit into from
Nov 30, 2025
Merged

Fiddle: change export to be all in styles.css and styles.scss #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,17 @@
"*.scss",
"*.css"
],
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js"
},
"./styles.css": "./dist/index.css",
"./styles.scss": "./src/styles.scss"
},
"files": [
"dist/*"
"dist/*",
"src/styles.scss"
],
"dependencies": {
"@kibalabs/core": "^0.6.3-next.4",
Expand Down
37 changes: 21 additions & 16 deletions src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
transition-duration: 0.3s;
width: 100%;
height: 100%;
box-sizing: border-box;
&.disabled {
cursor: not-allowed;
}
Expand All @@ -18,33 +19,37 @@
@layer kiba-theme {
.KibaDropzone {
--kiba-icon-size: 1.2em;
padding: var(--kiba-dropzone-padding, 0.75em 1em);
background-color: var(--kiba-dropzone-background-color, rgba(0, 0, 0, 0.02));
border-width: var(--kiba-dropzone-border-width, 1px);
border-color: var(--kiba-dropzone-border-color, rgba(0, 0, 0, 0.15));
border-style: var(--kiba-dropzone-border-style, dashed);
border-radius: var(--kiba-dropzone-border-radius, 0.25em);
color: var(--kiba-dropzone-color, rgba(0, 0, 0, 0.4));
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-wide2, 1.5em);
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS custom property --kiba-padding-wide2 has an unclear name. Consider using a more descriptive name like --kiba-padding-horizontal or --kiba-padding-x to better indicate this is the horizontal padding value, making the variable's purpose clearer for users of the theme system.

Suggested change
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-wide2, 1.5em);
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-horizontal, var(--kiba-padding-wide2, 1.5em));

Copilot uses AI. Check for mistakes.
background-color: var(--kiba-color-background-light05, rgba(0, 0, 0, 0.02));
border-width: var(--kiba-border-width, 1px);
border-color: var(--kiba-color-text-clear75, rgba(0, 0, 0, 0.25));
border-style: dashed;
border-radius: var(--kiba-border-radius, 0.5em);
color: var(--kiba-color-text-clear50, rgba(0, 0, 0, 0.5));
text-align: center;
font-size: var(--kiba-dropzone-font-size, 1rem);
font-size: var(--kiba-font-size, 1rem);
&:hover {
border-color: var(--kiba-dropzone-hover-border-color, rgba(0, 0, 0, 0.5));
color: var(--kiba-dropzone-hover-color, rgba(0, 0, 0, 0.5));
border-color: var(--kiba-color-brand-primary-clear50, rgba(0, 0, 0, 0.5));
color: var(--kiba-color-text-clear25, rgba(0, 0, 0, 0.75));
}
&:active {
border-color: var(--kiba-dropzone-active-border-color, rgba(0, 0, 0, 0.75));
color: var(--kiba-dropzone-active-color, rgba(0, 0, 0, 0.5));
border-color: var(--kiba-color-brand-primary, rgba(0, 0, 0, 0.75));
color: var(--kiba-color-text, rgba(0, 0, 0, 0.9));
}
&:focus {
outline: none;
border-color: var(--kiba-color-brand-primary-clear50, rgba(0, 0, 0, 0.5));
}
&.fileHovering {
border-color: var(--kiba-dropzone-file-hover-border-color, rgba(0, 0, 0, 0.75));
color: var(--kiba-dropzone-file-hover-color, rgba(0, 0, 0, 0.75));
border-color: var(--kiba-color-brand-primary, rgba(0, 0, 0, 0.75));
border-style: solid;
background-color: var(--kiba-color-brand-primary-clear90, rgba(0, 0, 0, 0.05));
color: var(--kiba-color-brand-primary, rgba(0, 0, 0, 0.75));
}
&.disabled {
background-color: var(--kiba-dropzone-disabled-background-color, rgba(128, 128, 128, 0.5));
color: var(--kiba-dropzone-disabled-color, rgba(128, 128, 128, 1));
background-color: var(--kiba-color-background-dark10, rgba(128, 128, 128, 0.1));
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.5));
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS variable name --kiba-color-text-clear75 suggests 75% transparency (25% opacity), but the fallback value rgba(128, 128, 128, 0.5) represents 50% opacity. This inconsistency could confuse theme consumers. Either the variable name should be --kiba-color-text-clear50 or the fallback should be rgba(128, 128, 128, 0.25) to match the naming convention.

Suggested change
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.5));
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.25));

Copilot uses AI. Check for mistakes.
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.25));
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS variable name --kiba-color-text-clear90 suggests 90% transparency (10% opacity), but the fallback value rgba(128, 128, 128, 0.25) represents 25% opacity. This inconsistency could confuse theme consumers. Either the variable name should be --kiba-color-text-clear75 or the fallback should be rgba(128, 128, 128, 0.1) to match the naming convention.

Suggested change
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.25));
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.1));

Copilot uses AI. Check for mistakes.
}
}
}
Loading