Skip to content

Fiddle: change export to be all in styles.css and styles.scss#13

Merged
krishan711 merged 1 commit into
mainfrom
export
Nov 30, 2025
Merged

Fiddle: change export to be all in styles.css and styles.scss#13
krishan711 merged 1 commit into
mainfrom
export

Conversation

@krishan711
Copy link
Copy Markdown
Contributor

Description

Screenshots:

Checklist:

  • I have updated the CHANGELOG with a summary of my changes
  • I have updated the documentation accordingly

Copilot AI review requested due to automatic review settings November 30, 2025 15:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the package exports to expose both the compiled CSS and source SCSS files as separate import paths, aligning with the broader Kiba theming system migration from component-specific CSS variables to a unified theme variable system.

  • Added package.json exports field to enable explicit imports of ./styles.css and ./styles.scss
  • Replaced component-specific CSS variables (e.g., --kiba-dropzone-*) with generic Kiba theme variables (e.g., --kiba-color-*, --kiba-border-*)
  • Added box-sizing: border-box to the structure layer for consistent sizing behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
package.json Added exports field mapping styles paths and updated files to include source SCSS for distribution
src/styles.scss Migrated from component-specific to generic Kiba CSS variables and added box-sizing property

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/styles.scss
border-style: var(--kiba-dropzone-border-style, dashed);
border-radius: var(--kiba-dropzone-border-radius, 0.25em);
color: var(--kiba-dropzone-color, rgba(0, 0, 0, 0.4));
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-wide2, 1.5em);
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS custom property --kiba-padding-wide2 has an unclear name. Consider using a more descriptive name like --kiba-padding-horizontal or --kiba-padding-x to better indicate this is the horizontal padding value, making the variable's purpose clearer for users of the theme system.

Suggested change
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-wide2, 1.5em);
padding: var(--kiba-padding-wide, 1em) var(--kiba-padding-horizontal, var(--kiba-padding-wide2, 1.5em));

Copilot uses AI. Check for mistakes.
Comment thread src/styles.scss
color: var(--kiba-dropzone-disabled-color, rgba(128, 128, 128, 1));
background-color: var(--kiba-color-background-dark10, rgba(128, 128, 128, 0.1));
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.5));
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.25));
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS variable name --kiba-color-text-clear90 suggests 90% transparency (10% opacity), but the fallback value rgba(128, 128, 128, 0.25) represents 25% opacity. This inconsistency could confuse theme consumers. Either the variable name should be --kiba-color-text-clear75 or the fallback should be rgba(128, 128, 128, 0.1) to match the naming convention.

Suggested change
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.25));
border-color: var(--kiba-color-text-clear90, rgba(128, 128, 128, 0.1));

Copilot uses AI. Check for mistakes.
Comment thread src/styles.scss
background-color: var(--kiba-dropzone-disabled-background-color, rgba(128, 128, 128, 0.5));
color: var(--kiba-dropzone-disabled-color, rgba(128, 128, 128, 1));
background-color: var(--kiba-color-background-dark10, rgba(128, 128, 128, 0.1));
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.5));
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS variable name --kiba-color-text-clear75 suggests 75% transparency (25% opacity), but the fallback value rgba(128, 128, 128, 0.5) represents 50% opacity. This inconsistency could confuse theme consumers. Either the variable name should be --kiba-color-text-clear50 or the fallback should be rgba(128, 128, 128, 0.25) to match the naming convention.

Suggested change
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.5));
color: var(--kiba-color-text-clear75, rgba(128, 128, 128, 0.25));

Copilot uses AI. Check for mistakes.
@krishan711 krishan711 merged commit 83e7bb3 into main Nov 30, 2025
10 checks passed
@krishan711 krishan711 deleted the export branch November 30, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants