fix: upgrade klone, vendor govulncheck workflow#682
Merged
Conversation
SgtCoDFish
force-pushed
the
govulncheck-fix-2
branch
5 times, most recently
from
64b3cdd to
20f149a
Compare
SgtCoDFish
changed the title
Contributor
Author
|
/hold WIP until cert-manager/makefile-modules#317 merges |
wallrj-cyberark
approved these changes
Aug 8, 2025
Contributor
wallrj-cyberark
left a comment
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Looks like you ran govulncheck workflow on this branch and it passed
https://github.com/jetstack/jetstack-secure/actions/workflows/govulncheck.yaml
But the nightly master version also seems to be passing so I might be misunderstanding what the problem is:
Contributor
Author
I did, but the klone.yaml is still pointing at my fork - I'll repoint at the upstream makefile-modules! |
It seems difficult to stop govulncheck attempting to pull and analyse private dependencies. We still want to run it, so the simplest thing to do is diverge from upstream makefile-modules and maintain the govulncheck workflow by hand in this repo. This requires changes to the govulncheck workflow itself, and means we have to disable the upstream govulncheck targets and copy them locally. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
force-pushed
the
govulncheck-fix-2
branch
from
20f149a to
7a69a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd mistakenly thought that govulncheck respected GOPRIVATE from local testing, but I'd actually set up an environment where govulncheck had access to the private dependency I was trying to avoid and as such it had passed locally and started to fail in CI.
This PR: