Simplify repo base generation#331
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
Bot
added
dco-signoff: yes
inteon
force-pushed
the
refactor_base_generation
branch
from
fb2acbd to
d4367ff
Compare
| # The base directory used to copy the govulncheck GH action from. This can be | ||
| # overwritten with an action with extra authentication or with a totally different | ||
| # pipeline (eg. a GitLab pipeline). | ||
| govulncheck_generate_base_dir ?= $(default_govulncheck_generate_base_dir) |
There was a problem hiding this comment.
This was not used, use dont_generate_govulncheck instead and manually maintain the yaml file.
inteon
force-pushed
the
refactor_base_generation
branch
from
d4367ff to
d1a99ac
Compare
| $(error bin_dir is not set) | ||
| endif | ||
|
|
||
| ifndef repo_name |
There was a problem hiding this comment.
Oh, I see. That variable is used elsewhere in other modules, just not in helm module so no need to error here if the variable is unset.
wallrj-cyberark
left a comment
wallrj-cyberark
left a comment
There was a problem hiding this comment.
I think I get it, but worried that the removal of govulncheck_skip will break the recent changes that Ash implemented.
Merge if you're confident that nothing's going to break.
| $(error bin_dir is not set) | ||
| endif | ||
|
|
||
| ifndef repo_name |
There was a problem hiding this comment.
Oh, I see. That variable is used elsewhere in other modules, just not in helm module so no need to error here if the variable is unset.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, wallrj-cyberark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
2 participants
We have a few "copy files into repo base" Makefile targets.
This PR updates them to use similar logic (including logic to template these files).