-
Notifications
You must be signed in to change notification settings - Fork 2
Homework #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZorianaPro
wants to merge
1
commit into
haensl:master
Choose a base branch
from
ZorianaPro:zozo-homework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Homework #2
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import React from 'react'; | ||
| import { useSelector } from "react-redux"; | ||
|
|
||
| const Greeting = ({ | ||
| userName, | ||
| loggedIn | ||
| }) => { | ||
|
|
||
| userName = useSelector(state => state.loginReducer.userName); | ||
| loggedIn = useSelector(state => state.loginReducer.loggedIn); | ||
| return ( | ||
| <div className="Greeting"> | ||
| {loggedIn ? `Hello ${userName}. Wassup?` : `Hmm, I don't know you ${userName}. Would you mind to log in?`} | ||
| </div> | ||
| ) | ||
| }; | ||
|
|
||
| export default Greeting; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| export const actions = { | ||
| login: 'LOGIN', | ||
| logOut: 'LOGOUT', | ||
| }; | ||
|
|
||
| export const login = () => ({ | ||
| type: actions.login | ||
| }); | ||
|
|
||
| export const logOut = () => ({ | ||
| type: actions.logOut | ||
| }); | ||
|
|
||
| export default { | ||
| login, | ||
| logOut | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import React from 'react'; | ||
| import { useSelector, useDispatch } from "react-redux"; | ||
| import { login, logOut } from './actions' | ||
|
|
||
| const Login = ({ | ||
| isLoggedIn | ||
| }) => { | ||
| isLoggedIn = useSelector(state => state.loginReducer.loggedIn); | ||
| const dispatch = useDispatch(); | ||
|
|
||
| const changeStatus = () => { | ||
| isLoggedIn ? dispatch(logOut()) : dispatch(login()) | ||
| }; | ||
|
|
||
| return ( | ||
| <button onClick={() => changeStatus()} | ||
| className="Login"> | ||
| { isLoggedIn ? 'Logout' : 'Login'} | ||
| </button> | ||
| ) | ||
| }; | ||
|
|
||
| export default Login; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { actions } from './actions'; | ||
|
|
||
| const initialState = { | ||
| loggedIn: false, | ||
| userName: 'guest' | ||
| }; | ||
|
|
||
| export default (state = initialState, action) => { | ||
| switch (action.type) { | ||
| case actions.login: | ||
| return { | ||
| loggedIn: true, | ||
| userName: 'not guest' | ||
| }; | ||
| case actions.logOut: | ||
| return { | ||
| loggedIn: false | ||
| }; | ||
| default: | ||
| return state; | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { combineReducers } from 'redux'; | ||
| import appReducer from './components/App/reducer'; | ||
| import loginReducer from './components/Login/reducer'; | ||
|
|
||
| export default combineReducers({ | ||
| appReducer, | ||
| loginReducer | ||
| }); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good Zozo :)
The only minor thing I would like to let you know: don't use the name Reducer in the state. If you import the reducer with the name of what it represents, your state will look nicer ;)
Example:
This way, in the other components where you use state, it just reads nicer - e.g.
becomes
So, you did veeeery good! 👍 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @haensl
I totally agree with your recommendation
Also I will add more stuff, to practice!