Open
Conversation
haensl
reviewed
Apr 28, 2020
| @@ -0,0 +1,9 @@ | |||
| import { combineReducers } from 'redux'; | |||
| import appReducer from './components/App/reducer'; | |||
Owner
There was a problem hiding this comment.
Looks all good Zozo :)
The only minor thing I would like to let you know: don't use the name Reducer in the state. If you import the reducer with the name of what it represents, your state will look nicer ;)
Example:
import app from './components/App/reducer';
import login from './components/Login/reducer';
export default combineReducers({
app,
login
});
This way, in the other components where you use state, it just reads nicer - e.g.
isLoggedIn = useSelector(state => state.loginReducer.loggedIn);
becomes
isLoggedIn = useSelector(state => state.login.loggedIn);
So, you did veeeery good! 👍 👍 👍
Collaborator
Author
There was a problem hiding this comment.
Thank you @haensl
I totally agree with your recommendation
Also I will add more stuff, to practice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create root reducer to combine reducers, create Login and Greeting components