Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-alpine-stable.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ RUN apk update && apk add gdb

# Speed up the CI builds using sccache.
WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ RUN apt-get update && \
apt-get --no-install-recommends install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ RUN apt-get update && \
apt-get --no-install-recommends install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-fedora.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24
RUN dnf makecache && dnf install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ RUN zypper refresh && \
zypper install --allow-downgrade -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24
RUN dnf makecache && dnf update -y && dnf install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ RUN apt-get update && \
apt-get --no-install-recommends install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ RUN apt-get update && \
apt-get --no-install-recommends install -y gdb

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ RUN curl -fsSL https://github.com/matus-chochlik/ctcache/archive/62631eb1c05688f
cd /var/tmp && rm -fr build

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ RUN curl -fsSL https://github.com/grpc/grpc/archive/v1.76.0.tar.gz | \
cd /var/tmp && rm -fr build

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24
ldconfig && cd /var/tmp && rm -fr build

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-m32.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24
ldconfig

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/gcc-oldest.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \
ldconfig && cd /var/tmp && rm -fr build

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).

RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)

tar -zxf - --strip-components=1 && \
mkdir -p /usr/local/bin && \
mv sccache /usr/local/bin/sccache && \
Expand Down