chore(deps): update dependency mozilla/sccache to v0.14.0#16019
chore(deps): update dependency mozilla/sccache to v0.14.0#16019renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the 'mozilla/sccache' dependency from version 'v0.10.0' to 'v0.14.0' across multiple Dockerfiles used in the CI/CD pipeline. This significant version bump incorporates numerous new features, performance enhancements, and broader compatibility, aiming to improve build caching efficiency and flexibility within the project's development infrastructure. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates sccache from v0.10.0 to v0.14.0 across multiple Dockerfiles. The changes are correct, but I've suggested an improvement to avoid hardcoding the version string in 15 different files. By using a build argument (ARG) for the version, future updates will be much simpler and less error-prone. This also aligns with the repository's style guide preference for avoiding code duplication.
| # Speed up the CI builds using sccache. | ||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid repeating the version string, consider defining the sccache version as a build argument. You can add ARG SCCACHE_VERSION=v0.14.0 at the top of the Dockerfile and then use the variable here. This aligns with the repository's preference for factoring out duplicated code (Repository Style Guide, lines 13-14).
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/${SCCACHE_VERSION}/sccache-${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The sccache version is duplicated across many Dockerfiles. (link)
2 participants
This PR contains the following updates:
v0.10.0→v0.14.0Release Notes
mozilla/sccache (mozilla/sccache)
v0.14.0Compare Source
Key improvements:
What's Changed
SCCACHE_BASEDIRSsupport by @Felixoid in #2521rustfmtandcargo fmtby @Felixoid in #2582cache_type_namemethod by @Felixoid in #2596storage_from_configby @Felixoid in #2597New Contributors
Full Changelog: mozilla/sccache@v0.13.0...v0.14.0
v0.13.0Compare Source
Key improvements:
package handling with /etc/ld.so.conf.d
What's Changed
CMAKE_MSVC_DEBUG_INFORMATION_FORMATin README by @Andrej730 in #2479New Contributors
Full Changelog: mozilla/sccache@v0.12.0...v0.13.0
v0.12.0Compare Source
What's Changed
New Contributors
Full Changelog: mozilla/sccache@v0.11.0...v0.12.0
v0.11.0Compare Source
sccache v0.11.0 introduces improved compiler flag support (including -fsanitize-ignorelist and Xclang flags), S3 virtual host endpoints, better logging with millisecond precision, expanded CI coverage (including sccache-dist and new platforms like s390x), and numerous fixes for reproducibility, Android builds, and preprocessor cache behavior. It also replaces legacy crates (num_cpus, retry), updates major dependencies (tokio, openssl, clap, ring), cleans up old code, and improves documentation and test reliability. This release welcomes 14 new contributors and continues modernizing the build and CI infrastructure.
What's Changed
v2tov4bump by @drahnr in #2341nvcc -timeandnvcc -fdevice-time-traceflags by @trxcllnt in #2355rustcby @bobrik in #2438--diagnostic-widthargument when computing hash by @shadaj in #2424Dependencies
New Contributors
Full Changelog: mozilla/sccache@v0.10.0...v0.11.0
Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.