Closed
Conversation
gherrit-pr-id: Gr4qottxa22y4kfhk2a5vctnhsswyoiac
This was referenced Mar 29, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gr4qottxa22y4kfhk2a5vctnhsswyoiac #3163 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6067 6067
==================================================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
f2b45f9 to
39a4877
Compare
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
39a4877 to
b232afc
Compare
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
b232afc to
080e06a
Compare
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
080e06a to
5198c12
Compare
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
5198c12 to
2d32a8e
Compare
While we're here, upgrade the Hermes CI workflow to run on the `ubuntu-24.04-64core` runner, which has 64 cores and 256GB of RAM. This allows our (very expensive) integration test suite to complete in a reasonable amount of time. While we're here, modify `.github/actions/cache/action.yml` to *only* restore the cache, not save it, when operating in "restore" mode. Previously, when operating in "restore" mode, that action used the `actions/cache` action, which both restores a cache *and* attempts to update it afterwards. We don't make use of the updated cache, and it adds overhead to CI execution which becomes very large now that we are running Hermes integration tests in CI, which generate a large disk footprint in `target`. gherrit-pr-id: Gliiuhmmjpxnlhekzzccdf2jteq6louuw
joshlf
force-pushed
the
Gliiuhmmjpxnlhekzzccdf2jteq6louuw
branch
from
2d32a8e to
b183481
Compare
Member
Author
|
Superseded by #3167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we're here, upgrade the Hermes CI workflow to run on the
ubuntu-24.04-64corerunner, which has 64 cores and 256GB of RAM. Thisallows our (very expensive) integration test suite to complete in a
reasonable amount of time.
While we're here, modify
.github/actions/cache/action.ymlto onlyrestore the cache, not save it, when operating in "restore" mode.
Previously, when operating in "restore" mode, that action used the
actions/cacheaction, which both restores a cache and attempts toupdate it afterwards. We don't make use of the updated cache, and it
adds overhead to CI execution which becomes very large now that we are
running Hermes integration tests in CI, which generate a large disk
footprint in
target.Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gliiuhmmjpxnlhekzzccdf2jteq6louuw && git checkout -b pr-Gliiuhmmjpxnlhekzzccdf2jteq6louuw FETCH_HEADCheckout
git fetch origin refs/heads/Gliiuhmmjpxnlhekzzccdf2jteq6louuw && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gliiuhmmjpxnlhekzzccdf2jteq6louuw && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.